After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547848 - gedit should not show a tab if only one document open
gedit should not show a tab if only one document open
Status: RESOLVED WONTFIX
Product: gedit
Classification: Applications
Component: general
2.23.x
Other All
: Normal minor
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 525914 573570 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-14 22:50 UTC by Moo
Modified: 2009-07-20 17:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Patch for this feature (2.06 KB, patch)
2008-11-18 23:34 UTC, Vincenzo Scotti
rejected Details | Review
Modified previous patch (852 bytes, patch)
2008-11-24 20:55 UTC, Vincenzo Scotti
none Details | Review

Description Moo 2008-08-14 22:50:58 UTC
Most of the time I use gedit, I only have one document open, not many tabs.
Yet it shows that tab bar which clutters the interface and steals space.

If you look at Firefox, when you only have one tab open, it does not show you the tab bar, it only is visible when you have two or more tabs open. This is much smarter.

Other information:
Comment 1 Vincenzo Scotti 2008-11-18 23:34:09 UTC
Created attachment 122994 [details] [review]
Patch for this feature

I got from svn a piece of code I supposed to do the same thing, but it didn't work at all.
So, I modified that line of code to get it working correctly.
Comment 2 Steve Frécinaux 2008-11-19 18:07:15 UTC
Downside: it makes it impossible to "pack" two windows by dragging the first tab to the second window...

BTW the feature would already be working if there was a way to set nb->priv->always_show_tabs to false. I'd go for a gconf key. Yours just drop the ability to have the current behaviour.
Comment 3 Giuseppe Fuggiano 2008-11-24 19:58:50 UTC
(In reply to comment #2)
> Downside: it makes it impossible to "pack" two windows by dragging the first
> tab to the second window...
> 
> BTW the feature would already be working if there was a way to set
> nb->priv->always_show_tabs to false. I'd go for a gconf key. Yours just drop
> the ability to have the current behaviour.

As a gedit user, I really don't mind if it always show tabs or not.  If there aren't opened document, it means I don't want to use gedit to edit files. :-)

What's the goal to have that gboolean?  What's the use case which needs gedit running with no document to edit?
Comment 4 Vincenzo Scotti 2008-11-24 20:55:52 UTC
Created attachment 123337 [details] [review]
Modified previous patch

I discussed about this on IRC with pbor.
He said that he wants the gboolean for APIs.
Ok, I don't disagree, but I think that is better to set always_show_tabs FALSE by default, and not TRUE.
I think that gedit will be nicer if it doesn't shows tab bar when there's only one document opened, but it will remain simple.
So the best solution is to set the gboolean always_show_tabs to FALSE.
I've attached a possible patch.
Comment 5 Ignacio Casal Quinteiro (nacho) 2008-12-30 20:16:28 UTC
You can always provide a plugin for it as standalone.
Comment 6 Moo 2008-12-31 16:05:39 UTC
Nautilus doesn't show tab when only one tab is open.
We need some standard here...
So the experience is unified and the same, not different in all applications.
Comment 7 Giuseppe Fuggiano 2009-01-01 04:15:59 UTC
(In reply to comment #6)
> Nautilus doesn't show tab when only one tab is open.
> We need some standard here...
> So the experience is unified and the same, not different in all applications.

In my opinion this is another, very important, argument to change that.  Also, in reply to comment #5, I think that a plugin isn't an elegant, useful, way to solve that problem at all, and if one will provide an extension, I expect it will be enabled by default.

Too much wasted time to set a gboolean to true which appears, to me and many other people, quite obvious.
Comment 8 Ignacio Casal Quinteiro (nacho) 2009-01-02 12:03:01 UTC
*** Bug 525914 has been marked as a duplicate of this bug. ***
Comment 9 Ignacio Casal Quinteiro (nacho) 2009-02-28 20:39:02 UTC
*** Bug 573570 has been marked as a duplicate of this bug. ***
Comment 10 Allan Day 2009-07-20 17:27:53 UTC
I also agree with comments #6 and #7 - consistency is the issue. Epiphany, GNOME Terminal and Nautilus all hide tabs when there is only one tab open. It's beneficial from both a usability and an aesthetic point of view to have as much consistency between applications as possible.

Could this bug be reopened?