After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547805 - should not filter applications using g_app_info_should_show()
should not filter applications using g_app_info_should_show()
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-08-14 17:32 UTC by Sebastien Bacher
Modified: 2013-09-13 01:00 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
don't use g_app_info_should_show() to filter applications (929 bytes, patch)
2008-08-14 17:35 UTC, Sebastien Bacher
committed Details | Review

Description Sebastien Bacher 2008-08-14 17:32:03 UTC
The current evolution version doesn't evince as a pdf viewer because it uses g_app_info_should_show() which filter applications using NoDisplay=true, filtering items based on what is listed in the menus or not doesn't seem to be the correct thing to do, not sure if applications which should not be listed should be filtered though and if gio has an api to do that or not
Comment 1 Sebastien Bacher 2008-08-14 17:35:18 UTC
Created attachment 116591 [details] [review]
don't use g_app_info_should_show() to filter applications
Comment 2 Matthias Clasen 2008-08-14 17:58:02 UTC
My take on this is that evo should show the same apps that nautilus would show.
Comment 3 Sebastien Bacher 2008-08-14 17:58:30 UTC
the issue has been discussed on #gnome-hackers and the patch seems to be correct, Hidden=true desktop are not listed by gio and other ones should not be filtered since evolution can be ran under other environment than GNOME
Comment 4 Matthew Barnes 2008-08-14 18:05:16 UTC
Approved.  Please commit.
Comment 5 Sebastien Bacher 2008-08-14 20:16:49 UTC
commited as revision 35993 to svn now