After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547305 - add API for retrieving GIcon and thumbnails from GtkRecentInfo
add API for retrieving GIcon and thumbnails from GtkRecentInfo
Status: RESOLVED DUPLICATE of bug 617174
Product: gtk+
Classification: Platform
Component: Class: GtkRecent
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
Emmanuele Bassi (:ebassi)
Depends on:
Reported: 2008-08-11 15:51 UTC by Emmanuele Bassi (:ebassi)
Modified: 2016-04-10 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

[PATCH] Add API for retrieving GIcon and thumbnail out of GtkRecentInfo (8.98 KB, patch)
2008-08-11 15:52 UTC, Emmanuele Bassi (:ebassi)
rejected Details | Review

Description Emmanuele Bassi (:ebassi) 2008-08-11 15:51:44 UTC
GtkRecentInfo has the ability to retrieve the GdkPixbuf of the MIME type icon. it should also be able to return the GIcon directly and query for the thumbnail.

since it adds API, and 2.13 is API frozen, this should go in after the branch for 2.15.
Comment 1 Emmanuele Bassi (:ebassi) 2008-08-11 15:52:54 UTC
Created attachment 116357 [details] [review]
[PATCH] Add API for retrieving GIcon and thumbnail out of GtkRecentInfo

 gtkrecentmanager.c |  206 +++++++++++++++++++++++++++++++++++++++++----
 gtkrecentmanager.h |    2 
 2 files changed, 190 insertions(+), 18 deletions(-)
Comment 2 Matthias Clasen 2008-09-18 16:04:53 UTC
There seems to be a bunch of unrelated fixes/optimizations in this patch, can
we get those committed separately ?

-        priv->filename = g_build_filename (g_get_home_dir (),
+        priv->filename = g_build_filename (g_get_user_data_dir (),

Is this a compatible change ? 

In the light of recent filechooser changes, do we want to add api to retrieve the file size ?

Please update since teags to 2.16, and add new functions to gtk.symbols and gtk-sections.txt
Comment 3 Emmanuele Bassi (:ebassi) 2008-09-18 16:31:17 UTC
yeah, the patch is a fluke - I'll mark it as rejected. this bug is more a reminder to me to fix this stuff than a real attempt at doing so. :-)

for the change in the file position I need to add code that checks the old file in case the new one hasn't been found.

as for the file size: yes, definitely.

I'll rework the patch as soon as possible.
Comment 4 Emmanuele Bassi (:ebassi) 2016-04-10 16:33:49 UTC
This has been fixed by commit b0fe3e49bbf788c9dd81d8c2f236666cc78d972d.

*** This bug has been marked as a duplicate of bug 617174 ***