After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547098 - evince should use the whole window for single page pdfs
evince should use the whole window for single page pdfs
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
2.22.x
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 524332 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-09 19:57 UTC by Greg Grossmeier
Modified: 2013-10-29 08:45 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Bugfix patch: Evince should use the whole window for single page pdfs (1.02 KB, patch)
2011-07-15 19:33 UTC, Daniel 		needs-work Details | Review
Opening single page pdfs in full window instead of dual mode (1.05 KB, patch)
2013-10-24 13:43 UTC, Spandana 		committed Details | Review

Description Greg Grossmeier 2008-08-09 19:57:48 UTC 
Originally reported in Launchpad: https://launchpad.net/bugs/256445
----



Binary package hint: evince

When displaying a single page pdf, evince still uses dual mode display, wasting half the screen real estate.

To reproduce:
1 set to dual mode by default
2 open a single page pdf

Expected:
full page display.

Proposed solution:
provide explicit single and dual page views, and 'smart' view which aims to optimise viewing area use.
Comment 1 Daniel 2011-07-15 19:33:28 UTC 
Created attachment 192056 [details] [review]
Bugfix patch: Evince should use the whole window for single page pdfs
Comment 2 Ricardo Fabbri 2011-08-02 02:53:23 UTC 
Hello. I'd like to check the status on this bug. Did it make it into the source tree?
Comment 3 Germán Poo-Caamaño 2013-05-02 07:06:21 UTC 
Review of attachment 192056 [details] [review]:

::: shell/ev-window.c
@@ +1272,3 @@
+		if (n_pages == 1)
+			ev_document_model_set_dual_page (window->priv->model, FALSE);
+		

I think Evince should honour the user setting for the document.

If the document is being opened for the first time, this could be a good option.  However, if the user set the document to dual page and then closed it, Evince should open it in the same state than the user closed it.
Comment 4 Germán Poo-Caamaño 2013-06-15 06:25:00 UTC 
*** Bug 524332 has been marked as a duplicate of this bug. ***
Comment 5 Spandana 2013-10-24 13:43:46 UTC 
Created attachment 258021 [details] [review]
Opening single page pdfs in full window instead of dual mode

When a new single page pdf is opened for first time, it opens in single page mode even if default mode is dual page. For other documents or documents opened previously, user preferences are honored.
Comment 6 Germán Poo-Caamaño 2013-10-25 06:59:24 UTC 
Review of attachment 258021 [details] [review]:

This parch looks good to me.  I would suggest to adjust the commit message to 72 columns, but that is only niptick.

Just to avoid any confusion.  This patch looks very similar to the previous one, but this is located in the right place.
Comment 7 Germán Poo-Caamaño 2013-10-25 07:13:55 UTC 
Review of attachment 258021 [details] [review]:

Also, don't forget to add the bugzilla url in the commit log.
Comment 8 Carlos Garcia Campos 2013-10-29 08:45:16 UTC 
Comment on attachment 258021 [details] [review]
Opening single page pdfs in full window instead of dual mode

Pushed to git master, thanks