GNOME Bugzilla – Bug 546972
unread message counts decrement but never increment, and will go negative (signed int problem)
Last modified: 2013-09-13 00:58:06 UTC
Please describe the problem: Not sure whether this is a bug in evo proper or in the exchange connector, but my "unread message" counts start at 0 when I sync; they don't get incremented when new mail arrives, but they then go negative when I mark previously-unread mail as read. (See screenshots, I'll attach as soon as bug is filed.) This also affects the bolding of folders that have unread mail in the mailbox summary pane. Steps to reproduce: 1. start evolution 2. observe read/unread counts for each subscribed folder 3. receive new mail, observe unread count does not increment 4. read mail, observe unread count goes negative Actual results: Expected results: unread mail should increment when new mail arrives and decrement when unread mail is read, but unread count should never go negative Does this happen every time? yes Other information: Note that the bold folder summary line is not exactly in sync with the unread count (nor does it seem to be offset precisely, either.) The screenshots are in chronological order, with the first one taken just after evo startup. ~x86 gentoo, using local ebuilds to get devel version of evolution and associated libs: evolution-exchange-2.23.6 evolution-data-server-2.23.6 evolution-2.23.6 gtkhtml-3.23.6 libsoup-2.23.6
Created attachment 116167 [details] post-startup, 2 emails actually unread
Created attachment 116168 [details] unread goes negative
Created attachment 116170 [details] zero mails _actually_ unread, but unread count is decrementing...
Created attachment 116171 [details] new mail arrived, but unread count did not increment
Created attachment 116172 [details] read the new mail, unread count decremented again
Which EXACT version do you use? .5, .6, svn trunk?
(In reply to comment #6) > Which EXACT version do you use? .5, .6, svn trunk? > That would be .6... (from initial bug text) > evolution-exchange-2.23.6 > evolution-data-server-2.23.6 > evolution-2.23.6 > gtkhtml-3.23.6 > libsoup-2.23.6 Thanks, Ole
Thanks Olegario Craig. Im looking into it and will fix it.
Exchange code, isn't fully adapted to disk summary. Bharath: are you finishing it for 2.23.90 ?
Exchange counts will be broken till Bharath fixes it.
Yup onto it now.
Created attachment 118561 [details] [review] Exchange patch Added SYNC_COUNT to sync up counts on the operations needed. Any operations that need syncing could just update the counts from mfld-> counts maintained at the mail side. So Camel could just pick it up from there. Attached patch fixes it.
Tested the patch on the latest trunk for the basic operations and it worked fine.
+ mail_stub_return_data (stub, CAMEL_STUB_RETVAL_RESPONSE, + CAMEL_STUB_ARG_UINT32, unread_count, + CAMEL_STUB_ARG_END); Add visible count also and commit to trunk. Thanks
just change and commit.
Changed and committed to trunk as r1792