After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546625 - gnome-terminal crashes when opening certain urls
gnome-terminal crashes when opening certain urls
Status: RESOLVED DUPLICATE of bug 546256
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal critical
: ---
Assigned To: Alexander Larsson
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-08-06 16:53 UTC by Patryk Zawadzki
Modified: 2008-08-06 17:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Description Patryk Zawadzki 2008-08-06 16:53:53 UTC 
I've caught this one yesterday when packaging the latest 2.23.6 packages. In rpm files we have lines such as this one:

Source0: http://ftp.gnome.org/pub/GNOME/sources/libgnomeui/2.23/%{name}-%{version}.tar.bz2

In previous releases g-t would only highlight the part before first '%' sign, for example:

http://ftp.gnome.org/pub/GNOME/sources/libgnomeui/2.23/

Now in 2.23.6 (with vte 0.17.1) it highlights and tries to open:

http://ftp.gnome.org/pub/GNOME/sources/libgnomeui/2.23/%{

Which results in an immediate terminal crash (it is also an incorrect URL as % is an escape character and is supposed to be followed by a hexadecimal number). I tend to forget about this bug only to lose some data on an hourly basis :)

Anyway it's hard for me to provide a stack trace as I don't have any other terminal apps installed but it's rather easy to reproduce:

1) echo 'http://ftp.gnome.org/pub/GNOME/sources/libgnomeui/2.23/%{'
2) ctrl+click the output of the previous command
Comment 1 Christian Persch 2008-08-06 17:02:32 UTC 
Program received signal SIGSEGV, Segmentation fault.

+ Trace 204730

Thread 3065047872 (LWP 10680)

  • #0 g_mount_spec_canonicalize_path
    at gmountspec.c line 480
  • #1 g_daemon_file_new
    at gdaemonfile.c line 99
  • #2 g_daemon_vfs_get_file_for_uri
    at gdaemonvfs.c line 374
  • #3 g_vfs_get_file_for_uri
    at gvfs.c line 123
  • #4 g_file_new_for_uri
    at gfile.c line 4852
  • #5 g_app_info_launch_default_for_uri
    at gappinfo.c line 557 

That URI is certainly invalid, but I'd expect g_app_info_launch_default_for_uri to return an error instead of just crashing on it.
Comment 2 Christian Kellner 2008-08-06 17:07:44 UTC 
That is dup. And its not gio that is the culprit but gvfs. Ubuntu ships even has a fix. SVN will also be properly fixed soonish.


*** This bug has been marked as a duplicate of 546256 ***
Comment 3 Patryk Zawadzki 2008-08-06 17:10:23 UTC 
Christian:

Should I file another bug for incorrectly highlighted URIs? The part highlighted by the terminal makes no sense as it should either stop before the % sign (previous behavior) or continue past the curly brace. If so, for which module/component?