After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546551 - Dialog for mark-all-read always mentions subfolders
Dialog for mark-all-read always mentions subfolders
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 617624 622363 623282 623283 624862 625035 625075 630634 632385 641234 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-06 09:31 UTC by Paul Bolle
Modified: 2011-02-02 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed Patch (2.35 KB, patch)
2010-01-15 09:37 UTC, Viswanath S 		committed Details | Review
evo patch (5.76 KB, patch)
2010-05-21 14:30 UTC, Milan Crha 		committed Details | Review

Description Paul Bolle 2008-08-06 09:31:41 UTC 
0) The dialog for deleting folders ("ask-delete-folder" in mail/mail.error.xml) always mentions subfolders:
  <error id="ask-delete-folder" type="question" default="GTK_RESPONSE_CANCEL">
    <_title>Delete "{0}"?</_title>
    <_primary>Really delete folder "{0}" and all of its subfolders?</_primary>
    <_secondary xml:space="preserve">If you delete the folder, all of its contents and its subfolders contents will be deleted permanently.</_secondary>
    <button stock="gtk-cancel" response="GTK_RESPONSE_CANCEL"/>
    <button stock="gtk-delete" response="GTK_RESPONSE_OK"/>
  </error>

1) It should be checked whether there actually are subfolders in a folder to be deleted. (Probably like the mark-all-read plugin does in mark-all-read/mark-all-read.c:mar_got_folder().)

2) The dialog should (I suppose) be split in two different dialogs (one for each situation).

3) Sorry, little time to work on that patch now.
Comment 1 Matthew Barnes 2008-08-06 13:50:20 UTC 
Confirming.
Comment 2 Paul Bolle 2008-08-31 12:12:31 UTC 
Similar too bug #518919 (which might be more general than just IMAP).
Comment 3 Paul Bolle 2008-09-01 12:09:27 UTC 
Similar issue: the ask-mark-all-read dialog (invoked by Folder > "Mark All Messages as Read"):

  <error id="ask-mark-all-read" type="question" default="GTK_RESPONSE_NO">
    <_title>Mark all messages as read</_title>
    <_primary>Do you want to mark all messages as read?</_primary>
    <_secondary xml:space="preserve">This will mark all messages as read in the selected folder and its subfolders.</_secondary>
    <button stock="gtk-no" response="GTK_RESPONSE_NO"/>
    <button stock="gtk-yes" response="GTK_RESPONSE_YES"/>
  </error>
Comment 4 Viswanath S 2010-01-15 09:37:18 UTC 
Created attachment 151459 [details] [review]
Proposed Patch
Comment 5 Matthew Barnes 2010-01-15 13:17:03 UTC 
Patch looks okay to me.  Would be nice to handle comment #3 too (not necessarily detect whether there's unread mail in subfolders, but just whether there -are- subfolders).
Comment 6 Bharath Acharya 2010-02-22 11:00:09 UTC 
Comment on attachment 151459 [details] [review]
Proposed Patch

Committed to master.
http://git.gnome.org/browse/evolution/commit/?id=8785fd3315996dffceec133f94096577a5547cbc
Comment 7 Milan Crha 2010-05-20 11:31:08 UTC 
Changing summary accordingly.
Comment 8 Milan Crha 2010-05-20 11:33:53 UTC 
*** Bug 617624 has been marked as a duplicate of this bug. ***
Comment 9 Milan Crha 2010-05-20 11:34:44 UTC 
Downstream bug report about the same:
https://bugzilla.redhat.com/show_bug.cgi?id=593874
Comment 10 Milan Crha 2010-05-21 14:30:06 UTC 
Created attachment 161648 [details] [review]
evo patch

for evolution;

mark-all-read part.
Comment 11 Milan Crha 2010-05-21 14:31:12 UTC 
Created commit a5d79e9 in evo master (2.31.2+)
Comment 12 Matthew Barnes 2010-06-22 11:36:17 UTC 
*** Bug 622363 has been marked as a duplicate of this bug. ***
Comment 13 Matthew Barnes 2010-07-01 11:14:46 UTC 
*** Bug 623283 has been marked as a duplicate of this bug. ***
Comment 14 Matthew Barnes 2010-07-01 11:15:03 UTC 
*** Bug 623282 has been marked as a duplicate of this bug. ***
Comment 15 Akhil Laddha 2010-07-21 04:16:45 UTC 
*** Bug 624862 has been marked as a duplicate of this bug. ***
Comment 16 Akhil Laddha 2010-07-23 03:38:26 UTC 
*** Bug 625075 has been marked as a duplicate of this bug. ***
Comment 17 Akhil Laddha 2010-07-23 03:41:07 UTC 
*** Bug 625035 has been marked as a duplicate of this bug. ***
Comment 18 Chris Lord 2010-07-23 13:45:41 UTC 
*** Bug 625035 has been marked as a duplicate of this bug. ***
Comment 19 Milan Crha 2010-10-19 10:54:04 UTC 
*** Bug 630634 has been marked as a duplicate of this bug. ***
Comment 20 Milan Crha 2010-11-03 12:16:27 UTC 
*** Bug 632385 has been marked as a duplicate of this bug. ***
Comment 21 Matthew Barnes 2011-02-02 14:23:30 UTC 
*** Bug 641234 has been marked as a duplicate of this bug. ***