After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546478 - Firefox directory is not found on Gentoo
Firefox directory is not found on Gentoo
Status: RESOLVED FIXED
Product: conduit
Classification: Other
Component: core
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: conduit-maint@gnome.bugs
conduit-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2008-08-05 21:10 UTC by Christian Schlotter
Modified: 2008-08-22 00:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for conduit/conduit (487 bytes, patch)
2008-08-05 21:11 UTC, Christian Schlotter
none Details | Review
conduit/conduit.patch (441 bytes, patch)
2008-08-05 21:20 UTC, Christian Schlotter
none Details | Review
Updated to explicity select /bin/bash (977 bytes, patch)
2008-08-10 05:39 UTC, John Stowers
none Details | Review
Removed /bin/bash dependency (894 bytes, patch)
2008-08-17 08:36 UTC, Christian Schlotter
committed Details | Review

Description Christian Schlotter 2008-08-05 21:10:14 UTC
On Gentoo, the path to run-mozilla.sh is /usr/lib/mozilla-firefox.
Comment 1 Christian Schlotter 2008-08-05 21:11:28 UTC
Created attachment 115934 [details] [review]
Patch for conduit/conduit

I suggest to apply the attached patch to conduit/conduit.
Comment 2 Christian Schlotter 2008-08-05 21:14:08 UTC
I suggest to apply the attached patch to conduit/conduit.
Comment 3 Christian Schlotter 2008-08-05 21:20:22 UTC
Created attachment 115935 [details] [review]
conduit/conduit.patch

This patch redirects stderr to /dev/null, in case a startup message like

 $ conduit
ls: cannot access /usr/lib*/firefox*: No such file or directory
INFO: FOUND FIREFOX LIBS AT /usr/lib/mozilla-firefox
...

is not wanted.
Comment 4 John Stowers 2008-08-10 05:38:01 UTC
This appears to be a bashism, and only works when I put /bin/bash at the top line. Any idea why?
Comment 5 John Stowers 2008-08-10 05:39:04 UTC
Created attachment 116275 [details] [review]
Updated to explicity select /bin/bash
Comment 6 Christian Schlotter 2008-08-10 07:21:12 UTC
(In reply to comment #4)
> This appears to be a bashism, and only works when I put /bin/bash at the top
> line. Any idea why?

Oh, I didn't notice this because on my system /bin/sh links to /bin/bash. The Bourne shell really does not support brace expansion[1]. If Bourne shell compatibility is needed, the ls can of course simply be replaced with
  ls -d /usr/lib*/firefox* /usr/lib*/mozilla-firefox* 2> /dev/null

[1] http://www.gnu.org/software/bash/manual/html_node/Major-Differences-From-The-Bourne-Shell.html#Major-Differences-From-The-Bourne-Shell
Comment 7 John Stowers 2008-08-10 08:01:22 UTC
Christian, would you mind commenting on bug #545464 for me please. Can you spot any bashisms in that particular case?
Comment 8 Christian Schlotter 2008-08-17 08:36:14 UTC
Created attachment 116785 [details] [review]
Removed /bin/bash dependency

I suggest this change which just needs a Bourne shell to work.
Comment 9 John Stowers 2008-08-22 00:57:36 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.