GNOME Bugzilla – Bug 546445
use informative names for accounts
Last modified: 2008-08-20 10:23:27 UTC
Empathy uses names like 'jabber1', 'jabber2' for accounts. It should default to using more informative names.
I agree. I guess the account name could be a good heuristic. Or maybe "%s (%s)" % (account_name, protocol) if we want to limit name clashes.
FWIW I would do: - "Jabber" (if there is only a single jabber account) - "jabber.org" (server name) (if there are jabber accounts on different accounts) - "fredp (jabber.org)" (if there are multiple accounts on the same server)
Going back any changing account names when you add a new account is a bit hairy. On the basis that having accounts on different protocols is more common than having multiple accounts on the same protocol, I'd go for "%s (%s)" % (protocol, account).
Frederic: While your proposition attracted me, it has a problem: I create my first jabber account so it gets named "Jabber", what happen when I create a 2nd jabber account? The first one get renamed? It seems a bit weird to me... I'll go for Robert's suggestion for now, we can make a more dynamic system later if needed.
That's the problem Robert pointed, the account should not be renamed; I am fine with (protocol, account).
I don't think dynamically renaming accounts is a problem at all. We should only include the account name for disambiguation. A comparable situation is the Gnome menu. If you install one web browser, the menu entry will be labelled "Web Browser". If you have more than one, the menu entries will be labelled "Epiphany Web Browser", etc.
The problem with dynamic renaming is that the user is also allowed to override the automatically given names, and then Empathy doesn't know particularly clearly whether the display name should be replaced with its automatically-decided one. Like: * Create MSN account #1. * Rename it to "Hotmail". * Create another MSN account. #1 gets renamed to "MSN (foofoo@hotmail.com)". * User is sad.
Surely Empathy can compare the name against the one it would have given it, or keep a list of which accounts should be automatically updated.
Fixed in my new-account branch: http://monkey.collabora.co.uk/empathy.git_new-account/
That branchn were merged. Closing the bug.