After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546353 - Statusbar in Trash does not show item counts for subfolders.
Statusbar in Trash does not show item counts for subfolders.
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.23.x
Other All
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-05 02:39 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2008-09-12 11:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Fix on nautilus_directory_is_local. (544 bytes, patch)
2008-09-11 03:42 UTC, Alvaro Vilanova Vidal 		none Details | Review
Fix on nautilus_directory_is_local (548 bytes, patch)
2008-09-11 03:52 UTC, Alvaro Vilanova Vidal 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2008-08-05 02:39:10 UTC 
There's no "item blah (contains N items)".
You can't know if the folder is full or not, which is one useful feature for trash I guess. And anyway it should be consistent with the rest of nautilus.

Major because consistency "must be a must" in our happy gnome land :).
Comment 1 Cosimo Cecchi 2008-08-05 12:37:48 UTC 
Confirming.
Comment 2 Alvaro Vilanova Vidal 2008-09-11 03:42:45 UTC 
Created attachment 118491 [details] [review]
Fix on nautilus_directory_is_local.

Hi! This is my first comment and I hope do more :)

This bug come from nautilus_directory_is_local(...) Only locals files are show. To find out if the directory is on local filesystem it calls to g_file_is_native. I'm not sure that this function should have been called here, the official documentation says something like "This does not mean the file is local..." (http://library.gnome.org/devel/gio/unstable/GFile.html#g-file-is-native)

The problem is that gio doesn't seem to manage GFiles with the URI "trash:///...". If you try to get de path for a GFile with these URI's, gio returns NULL.

Here is a possible solution.
Comment 3 Alvaro Vilanova Vidal 2008-09-11 03:52:30 UTC 
Created attachment 118492 [details] [review]
Fix on nautilus_directory_is_local

Ops... :P
Comment 4 Cosimo Cecchi 2008-09-11 08:31:40 UTC 
The approach looks fine to me. Christian?
Comment 5 Christian Neumair 2008-09-12 09:23:54 UTC 
Thanks for your work Alvaro. I committed an equivalent patch:

http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14615