After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546341 - [a11y] Goocanvas does not implement children-changed signal
[a11y] Goocanvas does not implement children-changed signal
Status: RESOLVED FIXED
Product: goocanvas
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: goocanvas-maint
goocanvas-maint
Depends on:
Blocks: 545431
 
 
Reported: 2008-08-05 00:38 UTC by John Stowers
Modified: 2008-11-10 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
First attempt at a patch (1.31 KB, patch)
2008-08-05 08:05 UTC, Damon Chaplin
committed Details | Review

Description John Stowers 2008-08-05 00:38:05 UTC
From
http://blogs.gnome.org/johncarr/2008/08/04/conduit-and-accessibility/

"We use GooCanvas, which is actually already accessible. Each item that is added to the canvas is available to accessibility tools, be it a raw canvas item or a gtk widget. Basic information such as its size and position is exposed without any effort on the part of the application author. Whilst experimenting, I have hit the following limitations:"

and

"2. GooCanvas doesn’t seem to implement the children-changed signal. In testing this has meant that accerciser is unaware of changes on the canvas, and i’ve needed to keep restarting accerciser."

I guess that children-changed should be emitted whenever a child items properties change, such as size, x/y, etc.
Comment 1 John Carr 2008-08-05 04:17:01 UTC
The children-changed signal should be emitted when a child item is added or removed from the canvas.

I was going to write a patch for this, but had it mentally queued for after my next round of hitting conduit with a stick. If someone wants to help me out here, it would be lovely :-)
Comment 2 Damon Chaplin 2008-08-05 08:05:47 UTC
Created attachment 115875 [details] [review]
First attempt at a patch

Here's a first go at a patch. It needs testing though.
Comment 3 John Carr 2008-08-05 15:53:50 UTC
Thanks very much for this Damon. I'll roll it in to my system and see what happens.
Comment 4 Murray Cumming 2008-09-30 08:37:11 UTC
John, do you have any feedback on that patch?
Comment 5 Damon Chaplin 2008-10-02 15:27:27 UTC
The patch was applied before GooCanvas 0.11, though it was changed slightly.
Comment 6 Murray Cumming 2008-11-10 16:37:40 UTC
Closing because the patch was applied.