After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545946 - WhereAmI fails on Gecko trees
WhereAmI fails on Gecko trees
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: Normal normal
: 2.24.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-08-02 04:36 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-03-10 00:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
add a check for ROLE_TREE (1.26 KB, patch)
2008-08-02 04:39 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-08-02 04:36:50 UTC 
In examining where things stood with the Firefox regression tests, I noticed that whereAmI was no longer working in one of the trees in the bookmark manager. The Gecko script's getCellIndex() needs to look at trees in addition to tables and tree tables. 

Patch to follow.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-08-02 04:39:20 UTC 
Created attachment 115718 [details] [review]
add a check for ROLE_TREE

This solves the problem. It's pylinted and regression tested and a safe/conservative change.
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-08-02 04:54:17 UTC 
Given the nature of the change, its limited scope, and the fact that beyond the regression tests, I've also tested this patch in the finite number of trees that exist in Gecko (both Firefox and Thunderbird), I've gone ahead and checked it in so that it makes the 2.23.6 release.

Moving to pending.