After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545623 - Revert to checking extents for navigating amongst line breaks
Revert to checking extents for navigating amongst line breaks
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: High normal
: 2.24.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403 404409 534431
 
 
Reported: 2008-07-31 01:33 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-03-10 00:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
revision 1 (4.81 KB, patch)
2008-07-31 01:37 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-07-31 01:33:16 UTC
Alastair reported on the Orca list:

---------------------
On the page http://www.gentoo.org/doc/en/power-management-guide.xml do a search for "listing 2.5" and try and arrow down through the lines which follow.  I've found that it gets stuck at certain points and just keeps saying blank and not moving down.  I then need to arrow right to get to the next line.  I've had a brief look at the html and the only possible cause i can see is the use of the span tags, but i can't reproduce the problem in html myself.
---------------------

It's not the spans; it's the double line breaks. :-(

As part of last release's line navigation refactor we largely abandoned the use of find{Previous,Next}CaretInOrder() and checking extents. As a result, we had to be clever about whitespace -- in particular line break characters. We're not being clever enough. As a result, we have the above issue as well as bug 534431 (skipping over line breaks when composing certain messages).

Rather than try to anticipate every case (which is becoming increasingly difficult given changes in Firefox 3.1 seem to include exposing whitespace differently from 3.0), we should rely upon checking extents when verifying that we have located a new line.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-07-31 01:37:40 UTC
Created attachment 115595 [details] [review]
revision 1

This patch seems to solve the problem Alastair reported, along with a new bug presented by changes in Firefox 3.1, along with another bug I've been meaning to address (noted in the regression tests), along with the thunderbird line break bug. It also passes the regression tests for 3.1. I want to run what we have against 3.0 to make sure we haven't blown up anything there.

Please test thoroughly. :-)
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-07-31 04:49:46 UTC
It seems to pass the FF3.0 tests as well -- keeping in mind the differences/fixes made in 3.1. 

Mike, Jon, and others, please pound on it. :-)
Comment 3 Mike Pedersen 2008-08-01 16:09:40 UTC
So far I'm finding no problems with this patch.  I've given it quite a bit of testing.
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-08-01 22:56:25 UTC
Mike and I chatted about this one and decided to check it in for the 2.23.6 release. Done. Moving to pending.