After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545219 - HIG Fixes
HIG Fixes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-28 20:10 UTC by Bastien Nocera
Modified: 2008-08-07 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
String changes (4.11 KB, patch)
2008-07-30 09:58 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-07-28 20:10:21 UTC
1.  Category headings should use title capitalization, so "Sound theme" should
read "Sound Theme" and "System sounds" should read "System Sounds".  
2.  There is a "P" mnemonic conflict.  See "_Play system sounds" and "_Play
system beep sound".
3.  There is no mnemonic for "Play sounds when buttons are pressed".
Comment 1 Bastien Nocera 2008-07-29 17:20:54 UTC
Waiting on Calum Benson's ideas for better strings.
Comment 2 Calum Benson 2008-07-29 23:14:11 UTC
My only real suggestion here would be to consider following the Mac's terminology, which is a bit more consumer-friendly: OS X calls the system beep/bell the "alert sound", and other event sounds "sound effects".

Going from the screenshots alone (i.e. I haven't had a chance to play with this yet), I think that would mean:

* "Play system beep sound" would become "Play alert sound"

* "Play sounds when buttons are pressed" might become "Play sound effects when buttons are pressed" (but it's probably fine as it is, too-- changing it to "sound effects" would just reinforce the relationship with the list below, if you were to make the next change too...)

* "System Sounds" list heading would become "Alerts and Sound Effects"

* "Audible bell" would become "Alert sound"

* "Visual bell" would become "Visual alert"
Comment 3 Calum Benson 2008-07-29 23:17:25 UTC
> Play sounds when buttons are pressed" might become "Play sound effects when
buttons are pressed"

Correction: the docs style guide says that GUI buttons should be "clicked", not "pressed".  (It's keys on the keyboard that are "pressed".)  So that should be "Play sound effects when buttons are clicked".
Comment 4 Bastien Nocera 2008-07-30 09:58:23 UTC
Created attachment 115550 [details] [review]
String changes

This better?
Comment 5 Calum Benson 2008-08-05 17:57:02 UTC
Yep, looks pretty reasonable to me...
Comment 6 Bastien Nocera 2008-08-07 19:15:23 UTC
Jens, could you please double-check and commit?
Comment 7 Jens Granseuer 2008-08-07 20:26:39 UTC
After some discussion with shaunm on IRC, I've changed "Toggle switched" to "Toggle button clicked", and I also found two more capitalization errors.

Committed and announcement sent. Thanks.
Comment 8 Bastien Nocera 2008-08-07 20:36:07 UTC
Thanks!