After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545151 - cheese should add video to the iconview even if thumbnailing fails
cheese should add video to the iconview even if thumbnailing fails
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-07-28 13:27 UTC by Filippo Argiolas
Modified: 2008-09-05 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use video-x-generic from icon theme if thumbnailing fails (1.60 KB, patch)
2008-07-28 13:33 UTC, Filippo Argiolas
none Details | Review

Description Filippo Argiolas 2008-07-28 13:27:31 UTC
After we switched to ogv extension (see bug #524021), since there is no registered thumbnailer for the "video/ogg" mimetype (the one associated with the new extension), the thumbnail generation in cheese_thumb_view_append_item always fails returning a "WARNING: could not load.." for each video file the the video directory.
The missing thumbnailer issue should hopefully be fixed in the next gnome release either by totem (bug #545130) or lignomeui (bug #545133) or by hand with gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command" "/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string.

Anyway I think that we should add "something" to the thumbnail view even if there is no thumbnailer or thumbnail generation fails for anything. 
Maybe using the "video-x-generic" icon from the current IconTheme could be a good solution, I think that's what nautilus does when no icon thumbnail is found.
Attaching a proposed patch.
Comment 1 Filippo Argiolas 2008-07-28 13:33:39 UTC
Created attachment 115427 [details] [review]
use video-x-generic from icon theme if thumbnailing fails

there are a couple of things I'm not quite sure about:
- is video-x-generic the best choice?
- the size of the icon is hardcoded to 96px, any better idea?
Comment 2 Filippo Argiolas 2008-07-29 07:30:21 UTC
just a little update, the right command to enable the thumbnailer by hand is:

gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command" "/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string
gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/enable" "true" --type boolean
Comment 3 Filippo Argiolas 2008-08-04 17:41:10 UTC
Fixed in svn. Also added a loading icon while generating thumbnail.
Comment 4 Zdravko Nikolov 2008-08-31 21:06:43 UTC
(In reply to comment #2)
> just a little update, the right command to enable the thumbnailer by hand is:
> 
> gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command"
> "/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string
> gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/enable" "true" --type
> boolean
> 

I tried this but it didn't work..
Comment 5 daniel g. siegel 2008-08-31 21:07:20 UTC
what happened? please be more verbose
Comment 6 Zdravko Nikolov 2008-08-31 21:12:47 UTC
(In reply to comment #5)
> what happened? please be more verbose
> 

I opened a terminal and did:

gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command" "/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string

gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/enable" "true" --type boolean

then restarted the system.

When I stareted cheese and tried to record a video I get
:
** (cheese:3342): WARNING **: could not generate thumbnail for /home/Zdravko/Videos/Webcam/2008-08-31-220808.ogv (video/ogg)


** (cheese:3342): WARNING **: could not generate thumbnail for /home/Zdravko/Videos/Webcam/2008-08-31-220808.ogv (video/ogg)


** (cheese:3342): WARNING **: could not generate thumbnail for /home/Zdravko/Videos/Webcam/2008-08-31-220808.ogv (video/ogg)


Comment 7 daniel g. siegel 2008-08-31 21:28:12 UTC
which version of cheese?
Comment 8 Zdravko Nikolov 2008-08-31 21:29:24 UTC
(In reply to comment #5)
> what happened? please be more verbose
> 

I opened a terminal and did:

gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command" "/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string

gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/enable" "true" --type boolean

then restarted the system.

When I stareted cheese and tried to record a video I get
:
** (cheese:3342): WARNING **: could not generate thumbnail for /home/Zdravko/Videos/Webcam/2008-08-31-220808.ogv (video/ogg)


** (cheese:3342): WARNING **: could not generate thumbnail for /home/Zdravko/Videos/Webcam/2008-08-31-220808.ogv (video/ogg)


** (cheese:3342): WARNING **: could not generate thumbnail for /home/Zdravko/Videos/Webcam/2008-08-31-220808.ogv (video/ogg)


(In reply to comment #7)
> which version of cheese?
> 

2.23.91
Comment 9 daniel g. siegel 2008-08-31 21:36:24 UTC
we do not have a 2.23.91 version (yet)?
Comment 10 Zdravko Nikolov 2008-08-31 21:40:18 UTC
(In reply to comment #9)
> we do not have a 2.23.91 version (yet)?
> 

it is svn r970
Comment 11 Zdravko Nikolov 2008-08-31 21:44:13 UTC
I believe the schema is missing for this to work..
Comment 12 daniel g. siegel 2008-08-31 21:51:37 UTC
gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command"
"/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string

wont work: /ur/bin/gnome-video-thumbnailer is definitely not the correct path to the thumbnailer
Comment 13 Zdravko Nikolov 2008-08-31 22:31:26 UTC
(In reply to comment #12)
> gconftool-2 -s "/desktop/gnome/thumbnailers/video@ogg/command"
> "/ur/bin/gnome-video-thumbnailer -s %s %u %o" --type string
> 
> wont work: /ur/bin/gnome-video-thumbnailer is definitely not the correct path
> to the thumbnailer
> 

yep, I changed this to /usr/bin/totem-vieo-thumbnailer but then again..it didn't work.
Comment 14 daniel g. siegel 2008-08-31 22:38:03 UTC
is that program installed on your computer?
Comment 15 Filippo Argiolas 2008-09-01 08:08:57 UTC
note that you shouldn't need those command anymore with latest totem (see bug  #545130)
Comment 16 Zdravko Nikolov 2008-09-01 08:17:39 UTC
(In reply to comment #15)
> note that you shouldn't need those command anymore with latest totem (see bug 
> #545130)
> 

I understand but the latest totem doesn't build under Gnome 2.22. There should be a patch I can apply to the 2.22 version. 
Comment 17 Filippo Argiolas 2008-09-01 09:11:02 UTC
>I understand but the latest totem doesn't build under Gnome 2.22. There should
>be a patch I can apply to the 2.22 version. 

No needed patch, you just need to use correct gconf settings for the thumbnailer.
Anyway we use ogv extension from 2.23.5 so you're not supposed to use it on gnome 2.22. If you want ogv thumbnailer on 2.22 too you could ask at totem developers, but I'm not sure if it's worth since it's just a matter of setting a gconf key as stated above.
Comment 18 Zdravko Nikolov 2008-09-01 09:21:54 UTC
(In reply to comment #17)
> >I understand but the latest totem doesn't build under Gnome 2.22. There should
> >be a patch I can apply to the 2.22 version. 
> 
> No needed patch, you just need to use correct gconf settings for the
> thumbnailer.
> Anyway we use ogv extension from 2.23.5 so you're not supposed to use it on
> gnome 2.22. If you want ogv thumbnailer on 2.22 too you could ask at totem
> developers, but I'm not sure if it's worth since it's just a matter of setting
> a gconf key as stated above.
> 

I don't think that the gconf solution works. I tried it and it failed. I run Fedora 9. The only solution I can think of is to patch cheese to save video as ogg again...
Comment 19 Zdravko Nikolov 2008-09-01 20:42:40 UTC
I can confirm now that the bug I see is not related to the ogv file extention. After reverting back to save in ogg the problem is still there - multiple video icons appear every 3 seconds... 
Comment 20 Zdravko Nikolov 2008-09-05 11:41:22 UTC
After a bit more of investigating, it looks like the problem is related to the higher resolutions. Anything up to 352x288 works (thumbnail of video is displayed only after the stop button is pressed), from 800x600 upwards it starts displaying thumbnails avery 3 sec or so.