After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544197 - Orca speaks nothing when first tabbing into the document frame in firefox
Orca speaks nothing when first tabbing into the document frame in firefox
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: Normal normal
: 2.24.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-07-22 16:20 UTC by Mike Pedersen
Modified: 2009-03-10 00:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
revision 1 (733 bytes, patch)
2008-07-28 05:43 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Mike Pedersen 2008-07-22 16:20:19 UTC 
1.  Open firefox
2.  Open a bug in bugzilla
3.  let the page finish loading
4.  tab once

Notice that orca speaks nothing when enteringg the document frame.  I guess because nothing really useful has focus we should just speak and braille "documennt frame"
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-07-23 16:38:15 UTC 
Confirmed. And at least for me, fixed by my patch to bug 544122. (That patch is a multi-fix thang). Mike please confirm that that patch fixes it for you.

Changing the target milestone to 2.23.90 to match the other bug (i.e. if that patch gets checked in, this bug will also be fixed).
Comment 2 Mike Pedersen 2008-07-23 21:15:47 UTC 
This one is better with the patch but not quite right.  Please try the following: 

1.  go to www.blindbargains.com
2.  Put focus on the address bar
3.  tab to the google search field.
4.  Tab again.  

Notice that you still hear nothing on this site.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-07-23 21:24:25 UTC 
I just tried it. When I give focus to the document frame, we present the following (taken from my debug.out):

BRAILLE LINE:  'Blind Bargains: Deals & News for the Blind & Visually Impaired'
     VISIBLE:  'Blind Bargains: Deals & News for', cursor=0
SPEECH OUTPUT: 'Blind Bargains: Deals & News for the Blind & Visually Impaired page'
SPEECH OUTPUT: 'Blind Bargains'
BRAILLE LINE:  'Blind Bargains'
     VISIBLE:  'Blind Bargains', cursor=1

If you're not seeing that, a debug.out would be helpful.  Thanks!
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-07-25 04:45:15 UTC 
Ignoring the differences you and I are seeing on blindbargains.com, I need to know exactly what we should be saying when the document frame is given focus after some other object (i.e. not in document content) had focus.  Should we:

1. Speak the current line always
2. Speak the current line, but only if we have an existing caret context
3. Never speak the current line
4. Something else

?

If you spec it, patch will come. Or something like that.... <grin>
Comment 5 Mike Pedersen 2008-07-25 15:25:57 UTC 
It seems to me like the best thing to do would be to always speak the line.
Comment 6 Joanmarie Diggs (IRC: joanie) 2008-07-28 05:43:38 UTC 
Created attachment 115411 [details] [review]
revision 1

Please test.
Comment 7 Mike Pedersen 2008-07-28 17:01:04 UTC 
Seems to work.  Thanks
Comment 8 Joanmarie Diggs (IRC: joanie) 2008-07-28 23:28:01 UTC 
Thanks Mike. Patch committed to trunk. Moving to pending.