GNOME Bugzilla – Bug 544039
[lame] Doesn't build with 3.97
Last modified: 2008-07-22 18:25:04 UTC
Hi, the lame plugin does not build anymore with lame 3.97 because of some deprecated functions: cc1: warnings being treated as errors gstlame.c: In function ‘gst_lame_init’: gstlame.c:612: error: implicit declaration of function ‘lame_get_padding_type’ gstlame.c: In function ‘gst_lame_setup’: gstlame.c:1206: error: implicit declaration of function ‘lame_set_padding_type’ gstlame.c:1231: error: implicit declaration of function ‘lame_set_cwlimit’ The functions are still in the library but the headers have the definitions hidden in a #if block. What shall we do about this? Deprecate the element properties too and make them useless as is done for the xing header property?
Confirmed also with 3.98
2008-07-22 Sebastian Dröge <sebastian.droege@collabora.co.uk> * ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init), (gst_lame_set_property), (gst_lame_get_property), (gst_lame_setup): * ext/lame/gstlame.h: Fix build with lame >= 3.97. The padding type and cwlimit settings are deprecated now and the function declarations are hidden in the headers so deprecate the GObject properties for them and remove them in 0.11. Fixes bug #544039.