After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543665 - support NC_()
support NC_()
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
unspecified
Other Linux
: High enhancement
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-18 22:03 UTC by Christian Persch
Modified: 2008-07-20 23:36 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Trivial patch to support NC_ (481 bytes, patch)
2008-07-20 18:36 UTC, Claude Paroz 		none Details | Review

Description Christian Persch 2008-07-18 22:03:18 UTC 
Intltool should support extraction of string marked using the NC_() no-op variant of C_() (added to glib in bug 536996).
Comment 1 Claude Paroz 2008-07-20 18:36:44 UTC 
Created attachment 114870 [details] [review]
Trivial patch to support NC_
Comment 2 Claude Paroz 2008-07-20 19:16:11 UTC 
I'm just realizing that C_ support in intltool 0.40 is broken :-( ...and my patch also.
xgettext requires an argument specifier when using contextual functions/macros. In this case, we should add "_C:1c,2" and "_NC:1c,2" instead of just _C or _NC. 

See also http://www.gnu.org/software/autoconf/manual/gettext/xgettext-Invocation.html, in the --keyword paragraph.

I don't know Perl enough to know exactly which char needs to be escaped, so I'm letting the patch to Perl'ers. I'm ready to test it, though.
Comment 3 Rodney Dawes 2008-07-20 23:36:07 UTC 
We do need to add the argument specifiers for C_ and NC_, yes. I don't know why exactly the = and _ were being escaped anyway. They are in strings and don't really need to be escaped.

I've fixed this in SVN now. Your patch was insufficient anyway, as there is also a regex in FindLeftoutFiles() which needed to be modified as well, so that intltool-update -m will properly detect them.