After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 542606 - German tax report excludes non-P/L accounts
German tax report excludes non-P/L accounts
Status: VERIFIED WONTFIX
Product: GnuCash
Classification: Other
Component: Reports
git-master
Other Linux
: Normal normal
: ---
Assigned To: Andreas Köhler
Andreas Köhler
Depends on:
Blocks: 473506
 
 
Reported: 2008-07-12 00:52 UTC by Rolf Leggewie
Modified: 2018-06-29 22:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mockup patch. Basic structure in place. Assigning of codes tbd. (2.98 KB, patch)
2008-07-15 13:35 UTC, Rolf Leggewie
none Details | Review
latest status (4.64 KB, patch)
2008-07-21 15:21 UTC, Rolf Leggewie
needs-work Details | Review

Description Rolf Leggewie 2008-07-12 00:52:19 UTC
I'll dig deeper into it tomorrow, but the tax report (which I think should be named "Umsatzsteuervoranmeldung" as that is more specific) does not show line 83 "Verbleibende Umsatzsteuer-Vorauszahlung".  It is likely that others are missing, too.
Comment 1 Jannick 2008-07-12 08:07:56 UTC
(In reply to comment #0)
> ... tax report (which I think should be
> named "Umsatzsteuervoranmeldung" as that is more specific) 

I agree.

In addition the tax report is not able to show any balance sheet account. It retrieves data from P&L accounts only. See bug 432143, too.

Comment 2 Jannick 2008-07-12 09:41:57 UTC
(In reply to comment #0)

Typically field 83 is automatically calculated. 
Comment 3 Rolf Leggewie 2008-07-12 12:16:23 UTC
(In reply to comment #2)
> Typically field 83 is automatically calculated.

yes, and the report should be the one doing the calculation, not the user.

man RechenKNECHT ;-)
Comment 4 Rolf Leggewie 2008-07-12 22:13:23 UTC
while my investigations have shown that there is also a small minor error in SKR04 (I expect there to be quite a few more) I have successfully verified that in fact there is also a fundamental road block here in the backend.  The report in its current form will indeed only show expense and income accounts.  For UStVa that is not sufficient.
Comment 5 Jannick 2008-07-12 23:06:53 UTC
Please see http://bugzilla.gnome.org/show_bug.cgi?id=432143#c13 for a workaround
Comment 6 Rolf Leggewie 2008-07-12 23:42:28 UTC
(In reply to comment #5)
> Please see http://bugzilla.gnome.org/show_bug.cgi?id=432143#c13 for a
> workaround

as commented in the other bug, that is hackery not a workaround.
Comment 7 Christian Stimming 2008-07-13 19:56:12 UTC
Sorry, I lost track of what we're discussion here. Do you mean reports/locale-specific/us/taxtxf-de_DE.scm somehow does not include asset/liability accounts in its calculation? In taxtxf-de_DE.scm I see only the function "validate" (line 434ff), but this doesn't even take the account-type into account (no pun intended, heh). The only other thing that might deal with income/expense only (and hence forget the asset/liabilities) is at line 342ff: The input to gnc:txf-get-category-key depends on the account-type, and this might be wrong. Maybe on an asset account the gnc:txf-get-category-key function needs to get txf-income-categories (or yet another list of txf categories), but right now it would get txf-expense-categories as input.

Apart from this, I have no clue at all and I will probably not add any further insight in the following weeks due to my lack of time. Sorry for that.
Comment 8 Rolf Leggewie 2008-07-14 09:33:41 UTC
Christian, thank you for your reply.

To sum up: Yes, this bug is about the locale-specific tax report not including asset & liability accounts in its calculations.  Where the problem is coming from?  Don't know, I was hoping to learn from you ;-)

From what you are describing, it sounds like txf-get-category-key being driven by txf-expense-categories might be to "blame" here.  I think txf-income-categories would be equally wrong, since I assume that would then exclude income and expense accounts.

The German tax report needs them all; assets, liabilities, income and expense.
Comment 9 Rolf Leggewie 2008-07-15 13:35:24 UTC
Created attachment 114596 [details] [review]
mockup patch.  Basic structure in place.  Assigning of codes tbd.

I think something along the lines of this patch might be able to get us what we want.

Christian, your guidance - your time - permitting would be greatly appreciated.
Comment 10 Rolf Leggewie 2008-07-17 11:50:44 UTC
If possible, I think this should make it into the 2.2.6 stable release.  Marking appropriately.
Comment 11 Rolf Leggewie 2008-07-21 13:50:19 UTC
Comment on attachment 114596 [details] [review]
mockup patch.  Basic structure in place.  Assigning of codes tbd.

The good news is, the patch does not break either build or run-time ;-)

The bad news is that even after including a definition for one payable account in src/tax/us/txf-de_DE.scm the issue at hand seems to be unaffected.
Comment 12 Rolf Leggewie 2008-07-21 15:21:30 UTC
Created attachment 114925 [details] [review]
latest status

This is my latest status, the report is still not created correctly. It looks to me the tax-report system borrowed from the US is really permeated with the assumption that only income and expense accounts matter.  I am not sure that fixing is less work than writing from scratch.

I cannot believe how difficult it is in gnucash to create a simple cross-table of "sum of transactions" aggregated by "accounts with tax-key XY".
Comment 13 Rolf Leggewie 2008-11-10 09:28:33 UTC
I'm currently leaning toward giving up completely on gnucash's reporting functions and pursuing a different venue.  Now that we have a fairly well-working SQL-backend, I think results will be easier and more sustainably gotten by storing gnucash data in an SQL database and using external tools such as Openoffice for reporting and charting.

I'd be OK with closing this report as WONTFIX or LATER in the sense of gnucash not being in shape to support the reporting necessary for German accounting.
Comment 14 Christian Stimming 2008-11-10 11:53:52 UTC
> I'd be OK with closing this report as WONTFIX or LATER in the sense of gnucash
> not being in shape to support the reporting necessary for German accounting.

Exactly.
Comment 15 John Ralls 2018-06-29 22:07:23 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=542606. Please update any external references or bookmarks.