After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 542125 - Migrate CompEditor to GtkUIManager
Migrate CompEditor to GtkUIManager
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.24.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-07-09 00:40 UTC by Matthew Barnes
Modified: 2013-09-13 00:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (412.32 KB, patch)
2008-07-09 00:46 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2008-07-09 00:40:59 UTC
Here's a patch to migrate CompEditor, CompEditorPage, and the various subclasses from BonoboUI to GtkUIManager.  It also cleans up the code significantly and streamlines the CompEditorPage API.
Comment 1 Matthew Barnes 2008-07-09 00:46:23 UTC
Created attachment 114222 [details] [review]
Proposed patch

This is another one of those enormous patches (135K lines).  I'm posting it here more for testing than code review.

I've given it a fair amount of testing already and I think I got all the major bugs fixed, but I could use another set of eyeballs checking the details.
Comment 2 Matthew Barnes 2008-07-10 01:01:34 UTC
> This is another one of those enormous patches (135K lines).

Slight exaggeration: 13K lines.  But still pretty big.
Comment 3 Chenthill P 2008-07-17 06:01:10 UTC
started reviewing this.
Comment 4 Chenthill P 2008-07-17 06:02:55 UTC
I just noticed teh comment at #1 that its more for testing. I will be doing that too :-)
Comment 5 Chenthill P 2008-07-17 13:53:06 UTC
As far as I have tested everything works fine. Its nice to see that the menu items are now pluggable. Skimmed through the patch and it looks good. Better to get this patch early to get more testing. Great work!!
Comment 6 Matthew Barnes 2008-07-17 14:03:45 UTC
Thanks!  I'll commit this in time for 2.23.5 then.
Comment 7 André Klapper 2008-07-17 14:20:46 UTC
Get it in even earlier so it gets testing before 2.23.5 comes out ;-)
Comment 8 André Klapper 2008-07-17 14:21:27 UTC
-/* Translators: "Read" as in "has been read" (em-filter-i18n.h) */

Please do keep that comment. Thanks.
Comment 9 Matthew Barnes 2008-07-18 16:35:42 UTC
Committed to trunk (revision 35753).

Removed the em-filter-i18n.h hunk before committing.  How does that thing keeps creeping into patches?