GNOME Bugzilla – Bug 542125
Migrate CompEditor to GtkUIManager
Last modified: 2013-09-13 00:59:39 UTC
Here's a patch to migrate CompEditor, CompEditorPage, and the various subclasses from BonoboUI to GtkUIManager. It also cleans up the code significantly and streamlines the CompEditorPage API.
Created attachment 114222 [details] [review] Proposed patch This is another one of those enormous patches (135K lines). I'm posting it here more for testing than code review. I've given it a fair amount of testing already and I think I got all the major bugs fixed, but I could use another set of eyeballs checking the details.
> This is another one of those enormous patches (135K lines). Slight exaggeration: 13K lines. But still pretty big.
started reviewing this.
I just noticed teh comment at #1 that its more for testing. I will be doing that too :-)
As far as I have tested everything works fine. Its nice to see that the menu items are now pluggable. Skimmed through the patch and it looks good. Better to get this patch early to get more testing. Great work!!
Thanks! I'll commit this in time for 2.23.5 then.
Get it in even earlier so it gets testing before 2.23.5 comes out ;-)
-/* Translators: "Read" as in "has been read" (em-filter-i18n.h) */ Please do keep that comment. Thanks.
Committed to trunk (revision 35753). Removed the em-filter-i18n.h hunk before committing. How does that thing keeps creeping into patches?