GNOME Bugzilla – Bug 541424
Make the sidebar look like EOG's
Last modified: 2013-02-18 05:41:43 UTC
this bug has been filed here: https://bugs.edge.launchpad.net/ubuntu/+source/evince/+bug/230700 "Evince and EOG are, in a way, similar apps: their purpose is to view specific kinds of documents. Having their sidebars look the same would increase visual integration. I think Evince's sidebar should look like EOG's, mimicking the rounded borders that nautilus has too. " Mockup: http://launchpadlibrarian.net/14539868/Pantallazo-1.png Thanks,
Thanks, nice idea
Created attachment 121340 [details] [review] (preliminary) patch which makes the thumbnail selection in the sidebar look (almost) like EOG's This patch adds the rounded selection rectangle to the sidebar's thumbnails (see screenshot in the next attachment). The selection itself resembles exactly the way EOG's selections look like. The only problem with this patch is that the page number of each thumbnail is not centered under the thumbnail anymore. For some reason I can't get the GtkIconView to do this with my custom cell renderer for the thumbnail. I'd gratefully embrace any pertinent hints on how to achieve this :-) While this patch is an improvement to the current situation imho, it's a matter of taste whether it could be applied as it is or not. In any case, I'm also going to try some other approaches to getting this bug fixed with the page numbers centered under the thumbnails.
Created attachment 121341 [details] Evince' sidebar look with my (preliminary) patch applied
(adding myself to CC list)
GtkIconView already has a rounded selection rectangle, isn't it enough? or can we close this bug now?
Christian, can you comment on Carlos' question in comment #5? Carlos, if I am not mistaken, then Evince does already do what this bug reports tries to fix, no? If so, could we close this bug as OBSOLETE?
Oh, I must have overlooked Carlos’ question. As for the GtkIconView I’m not sure whether there is actually any simple way to force a rounded selection rectangle if the current theme uses no rounded corners for selections. Probably that is also the reason why EOG had a custom cell renderer until at least the 2.26 series. Since 2.28 this custom cell renderer appears to be removed in EOG, though. And this probably also makes this bug obsolete. Now the selection rectangle only depends on the currently used theme for both apps. Thereby either both Evince and EOG have rounded selection rectangles for their thumbnails or none of them has.
What is the status of this bug? If it's obsolete, it should be marked as such.
Does eog still have its own cell renderer? maybe we could use it as a workaround for bug #646055, although a patch to fix GtkIconView in GTK 3.0 would be much better.
I've checked this issue in Evince 3.7.1. It seems, this bug can be closed as FIXED, because sidebar uses rounded selection rectangles as it was requested by jorchube.
In http://git.gnome.org/browse/evince/commit/?id=1e88e7fd7 was introduced a custom cell renderer, which also fixes this bug.