After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541413 - missing ifdefs for usage of pam_xauth_data feature from libpam
missing ifdefs for usage of pam_xauth_data feature from libpam
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-03 16:33 UTC by Mirco Müller
Modified: 2008-07-14 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch adding missing ifdef-guards for usage of struct pam_xauth_data from libpam >= 0.99.10.0 (754 bytes, patch)
2008-07-03 16:35 UTC, Mirco Müller
none Details | Review

Description Mirco Müller 2008-07-03 16:33:46 UTC
There are some parts in gdm/daemon/gdm-session-worker.c which do lack #ifdef-guards to disable the use of the struct pam_xauth_data from libpam, if the installed version of libpam is < 0.99.10.0, the attached patch fixes that issue by adding the missing #ifdef-guards.
Comment 1 Mirco Müller 2008-07-03 16:35:24 UTC
Created attachment 113934 [details] [review]
patch adding missing ifdef-guards for usage of struct pam_xauth_data from libpam >= 0.99.10.0
Comment 2 Luis Medinas 2008-07-06 21:23:29 UTC
This patch fixes build problems in current svn trunk looks good to me commit please.
Comment 3 Ray Strode [halfline] 2008-07-07 17:02:08 UTC
You already commited this, right Mirco?
Comment 4 Mirco Müller 2008-07-08 09:23:14 UTC
I don't have commit-rights as far as I know, Ray. What's the process to obtain the needed permissions? What requirements does one have to fulfil to successfully apply?
Comment 5 Ray Strode [halfline] 2008-07-08 13:41:17 UTC
Hi,

Read and follow http://live.gnome.org/NewAccounts

In the comments field of the form say you're working on a new greeter for GDM and doing various other fixes to the codebase and that Ray Strode sent you there to get svn access.
Comment 6 Luis Medinas 2008-07-08 14:07:17 UTC
meanwhile if the maintainer agrees i can commit to svn trunk for you.
Comment 7 Ray Strode [halfline] 2008-07-08 14:59:49 UTC
Go ahead and commit it Luis.  Small things like build fixes should need a lot of review/red tape.
Comment 8 Luis Medinas 2008-07-08 19:22:12 UTC
Thanks Ray... commited to svn trunk.

2008-07-08  Luis Medinas  <lmedinas@gnome.org>

        * daemon/gdm-session-worker.c (gdm_session_worker_initialize_pam):

        Added missing ifdefs for usage with pam_xauth_data feature
        from libpam. Patch from Mirco Müller <macslow@bangang.de>.
        Closes bgo #541413.
Comment 9 Mirco Müller 2008-07-14 11:04:21 UTC
I applied for commit-access now and also changed my eMail-address to better reflect my affiliation.