After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541045 - Task attachment w/o mime type causes segfault when opened (w/ patch)
Task attachment w/o mime type causes segfault when opened (w/ patch)
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Tasks
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-07-01 08:39 UTC by Keith Packard
Modified: 2009-09-03 12:44 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Use application/octet-stream when attachment is missing mime type (1.37 KB, patch)
2008-07-01 08:45 UTC, Keith Packard 		committed Details | Review

Description Keith Packard 2008-07-01 08:39:10 UTC 
A task with a type-less attachment caused a seg fault when it was opened in evolution. The crash was traced back to a failure to detect the missing mime type and substitute our favorite 'application/octet-stream' in its place. The attached patch does as much, which is probably a kludge, but prevents at least this crash.
Comment 1 Keith Packard 2008-07-01 08:45:58 UTC 
Created attachment 113760 [details] [review]
Use application/octet-stream when attachment is missing mime type
Comment 2 Srinivasa Ragavan 2008-07-01 09:53:29 UTC 
Fejj, can you look at this patch? Thanks
Comment 3 Srinivasa Ragavan 2008-07-20 18:19:39 UTC 
Do you have any scenario/mbox/ical file to reproduce the issue ?
Comment 4 Keith Packard 2008-07-21 00:31:16 UTC 
Sadly, the cases that were crashing were all full of secret stuff, and now that I've been running with my patch in place, I haven't had any further crashes.

If I can recall what caused this, it was an email with an attachment (probably power point) that I converted to a task; that caused the mime type from the attachment to be lost (a separate bug, surely). Opening the generated task caused the fault.
Comment 5 Srinivasa Ragavan 2008-08-31 05:23:32 UTC 
Anyways, seems safe to me. so commit to trunk
Comment 6 Suman Manjunath 2008-09-01 03:27:07 UTC 
Patch committed to SVN trunk as r9456
http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=9456
Comment 7 Milan Crha 2008-09-24 14:16:36 UTC 
Why is this still opened?