After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540124 - Orca couldn't read the warning message of theme.
Orca couldn't read the warning message of theme.
Status: RESOLVED WONTFIX
Product: orca
Classification: Applications
Component: speech
2.23.x
Other All
: Normal normal
: FUTURE
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-25 09:38 UTC by Ye Guo
Modified: 2009-01-21 15:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Orca debug log (220.17 KB, application/octet-stream)
2008-07-03 06:40 UTC, Ye Guo
  Details
Patch to check for locusOfFocus == None in onStateChanged (3.05 KB, patch)
2008-07-08 18:59 UTC, Willie Walker
none Details | Review
Screenshot (53.50 KB, image/png)
2008-08-07 17:31 UTC, Willie Walker
  Details

Description Ye Guo 2008-06-25 09:38:02 UTC
Please describe the problem:
Orca couldn't read the warning message of theme.

Steps to reproduce:
1. Launch orca by clicking "Launch ->All Applications->Universal Access->Orca Screen Reader And Magnifier".
2. Right click the desktop, select "Desktop Backgroud".
3. Go to the "Theme" tab, and select "LargePrint" by <Tab> and arrow key.
Then it will popup the warning message as follows:
The theme will not look as intended because the required icon theme "LargePrint" isn't installed.


Actual results:
Orca couldn't read the warning message. 

Expected results:
Orca should read the warning message. 

Does this happen every time?
Yes.

Other information:
Operating system: Solaris_Nevada_92+Vermillion_93
Comment 1 Willie Walker 2008-07-02 14:56:49 UTC
I cannot reproduce the warning message dialog, and have tried several things to force it to appear.  So...can you please create an Orca debug log that captures the events associated with this problem?  The instructions can be found at http://live.gnome.org/Orca/Debugging, and please post the resulting log here as an attachment.  Thanks!
Comment 2 Ye Guo 2008-07-03 06:40:01 UTC
Created attachment 113893 [details]
Orca debug log
Comment 3 Ye Guo 2008-07-03 06:41:48 UTC
Comment on attachment 113893 [details]
Orca debug log

Orca debug log is attached here
Comment 4 Willie Walker 2008-07-08 16:26:03 UTC
Thanks!  At line 2373 in the debug file, I see this traceback:

Traceback (most recent call last):
  • File "/usr/lib/python2.4/vendor-packages/orca/script.py", line 319 in process
    ObjectEvent     self.listeners[key](event)
  • File "/usr/lib/python2.4/vendor-packages/orca/default.py", line 3655 in onSta
    teChanged     state = orca_state.locusOfFocus.getState()
AttributeError: 'NoneType' object has no attribute 'getState'

This is due to the locusOfFocus being set to None due to the nautilus window deactivation at line 2173.  After that, the gnome-appearance-properties app then seems to build up its dialog and ultimately issues a window-activated event and a focus event, but not before it issues the state changed event.

I think all we might need to do in this case is just include a defensive check for locusOfFocus not being None.

Comment 5 Willie Walker 2008-07-08 18:59:29 UTC
Created attachment 114206 [details] [review]
Patch to check for locusOfFocus == None in onStateChanged

This patch checks to make sure locusOfFocus exists before doing work with it in onStateChanged.  Since I cannot reproduce the bug, can you please try building/installing Orca with this patch and testing it ye.guo?
Comment 6 Ye Guo 2008-07-10 10:12:49 UTC
Orca still couldn't read the warning message after I builded and installed it with the patch.
Comment 7 Willie Walker 2008-07-16 16:01:42 UTC
How did you get your system into a state where the LargePrint theme was messed up?  I've tried hard to do this on purpose, but cannot seem to achieve the desired effect of messing my machine up.  :-(
Comment 8 Tim Miao 2008-07-17 02:59:42 UTC
Hi Will, we will re-test this bug with vermillion_95 and give update by then. Hoping gnome-appearance-properties working well on build 95.
Comment 9 Willie Walker 2008-08-07 17:31:20 UTC
Created attachment 116083 [details]
Screenshot

While testing on Ubuntu, I came across the following dialog -- I highlighted the message in red.  This message appears in the same dialog as the theme selection dialog instead of a separate popup dialog -- is this what you are observing?
Comment 10 Willie Walker 2008-08-07 17:57:41 UTC
(In reply to comment #9)
> Created an attachment (id=116083) [edit]
> Screenshot

If this is indeed it, what we're getting as notification that this message appeared is the following event:

vvvvv PROCESS OBJECT EVENT object:state-changed:showing vvvvv
OBJECT EVENT: object:state-changed:showing             detail=(1,0)
    app.name='gnome-appearance-properties' name='None' role='filler' state='enabled horizontal sensitive showing visible' relations=''
^^^^^ PROCESS OBJECT EVENT object:state-changed:showing ^^^^^

The filler that appears ends up having a filler which in turn has another filler which in turn has two icons and a label.  One of the icons doesn't seem to be visible whereas the other is the warning icon.  The label is the warning text that is shown.

We could potentially write some code to detect that a filler has suddenly appeared in an already showing filler and then automatically speak icons and labels it might find underneath that filler.  

Alternatively, we could potentially just call this bad UI design and request that the app pops up a real error dialog.  As an example, I'm guessing that in all my attempts to reproduce this problem, I was looking for an error dialog and never noticed the message.
Comment 11 Willie Walker 2009-01-21 15:58:13 UTC
Closing as WONTFIX.  We looked at this and decided it's not mandatory to automatically present this information to the user.  The user can still browse for it if needed, however.