After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540051 - Add support for more mmkeys
Add support for more mmkeys
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 539915
Blocks: 545555 642299
 
 
Reported: 2008-06-24 22:16 UTC by Bastien Nocera
Modified: 2011-02-14 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support for more mmkeys (1.86 KB, patch)
2008-06-24 22:16 UTC, Bastien Nocera 		none Details | Review
Share the offsets with LIRC (2.40 KB, patch)
2008-07-02 11:35 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2008-06-24 22:16:13 UTC 
Support for:
FastForward
Rewind
Repeat
Shuffle
Comment 1 Bastien Nocera 2008-06-24 22:16:40 UTC 
Created attachment 113372 [details] [review]
Support for more mmkeys
Comment 2 Jonathan Matthew 2008-07-01 13:15:57 UTC 
Looks fine to me; feel free to commit whenever the underlying stuff is ready.

We should probably make the lirc plugin seek offsets the same as the ones you've used here.  It's currently using -10/+10, which was probably an arbitrary choice at some point.
Comment 3 Bastien Nocera 2008-07-02 11:35:34 UTC 
Created attachment 113849 [details] [review]
Share the offsets with LIRC
Comment 4 Jonathan Matthew 2008-09-14 09:32:39 UTC 
This seems to have been committed (perhaps accidentally): http://svn.gnome.org/viewvc/rhythmbox?view=revision&revision=5866

Is there any more that needs to be done here?
Comment 5 Bastien Nocera 2008-09-14 12:35:17 UTC 
Sigh. I really need to stop committing things by mistake...

I made a dummy commit to have this in the changelog

2008-09-14  Bastien Nocera  <hadess@hadess.net>

	* plugins/mmkeys/rb-mmkeys-plugin.c: Add support for
	the Repeat, Shuffle, and fwd/rew keys (even though
	X doesn't support them yet) (Closes: #540051)