After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540039 - Newly focused message not spoken after message deletion in Thunderbird if a message is open
Newly focused message not spoken after message deletion in Thunderbird if a m...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: Normal normal
: 2.24.0
Assigned To: Rich Burridge
Orca Maintainers
: 539975 (view as bug list)
Depends on:
Blocks: 404409
 
 
Reported: 2008-06-24 20:47 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-06-27 16:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Orca debug log generated whilst testing this problem. (64.50 KB, text/plain)
2008-06-24 21:28 UTC, Rich Burridge
  Details
Revision #1. (2.33 KB, patch)
2008-06-25 16:27 UTC, Rich Burridge
none Details | Review
revision 2 (3.71 KB, patch)
2008-06-25 18:04 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review
Orca debug log generated whilst testing this problem. (619.85 KB, text/plain)
2008-06-25 18:20 UTC, Rich Burridge
  Details

Description Joanmarie Diggs (IRC: joanie) 2008-06-24 20:47:19 UTC
Steps to reproduce:

* Start Orca
* Start Thunderbird
* Tab to the list of mail folders and select a folder.
* Tab to the mail header list for that folder, arrow down
  and press Return to open up one of the messages.
* Press Delete to delete that mail message.

At this point, what should happen is that a new message will appear in an open window in place of the message that was just deleted.

What actually happens is Thunderbird crashes.  Having the patch for bug 539975 will prevent the crash. However, when the new message is displayed, Orca says nothing to indicate this.
Comment 1 Rich Burridge 2008-06-24 21:28:51 UTC
Created attachment 113370 [details]
Orca debug log generated whilst testing this problem.
Comment 2 Rich Burridge 2008-06-25 16:27:40 UTC
Created attachment 113413 [details] [review]
Revision #1.

This was a combined effort with Joanie (thanks!).
Note that you will also need to apply the patch
from bug #539975, i.e.:
http://bugzilla.gnome.org/attachment.cgi?id=113362
to prevent Thunderbird from crashing.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-06-25 18:04:24 UTC
Created attachment 113425 [details] [review]
revision 2

Rich and I are tag-teaming again. :-)

This version does a couple of things:

1) Combines Rich's patch for this bug with my patch for the crasher bug.  That should make testing less of a hassle.

2) Adds some code to present the line when we get the accessible name change for the frame.  This will make us consistent with our behavior when a message is opened as well as when the first opened message is deleted and a new one takes its place.

Rich, look okay to you?
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-06-25 18:12:19 UTC
*** Bug 539975 has been marked as a duplicate of this bug. ***
Comment 5 Rich Burridge 2008-06-25 18:20:10 UTC
Created attachment 113427 [details]
Orca debug log generated whilst testing this problem.

> Rich, look okay to you?

I'm not sure. What do the braille users want here?
What is being shown, (both when you initially display
an open mail message window, and after you've just
deleted one and are focused on the next message), is
just the first line of the body of the mail message
(see line 12582 for example). There is no braille 
context information given before that.

Is that what we want?
Comment 6 Joanmarie Diggs (IRC: joanie) 2008-06-25 18:26:51 UTC
Sounds like a question for our UI Guy. :-)  Adding Mike's name to the summary.
Comment 7 Mike Pedersen 2008-06-25 18:37:12 UTC
In this case the user just wishes to see the first line of the message.  
Comment 8 David Price 2008-06-25 20:58:54 UTC
Hi, 

This is working as advertised.  I hear the new subject, followed by the first line of the message. However, two issues...

First, if the user has their preferences configured to automatically read messages when they are opened, should the entire message be read? (I admit that this is a bit problematic at the moment because, at least on my system, the automatically read messages doesn't work--one of the many bugs that I haven't had time to get verified and then file.)

Second, I think there is another Mozilla bug. I sent myself three messages to do this test. When I deleted the third message, which was the last in the message list, the message view window disappeared (I presume planned behavior)  and focus in the message list jumped will up the list--guessing here, but I think to the top message in the message list that is showing in the main Thunderbird window.  (My messages are sorted ascending by message arrival.)  A random jump up the list seems inappropriate behavior.  Can anyone else duplicate this?

Thanks.
Comment 9 Rich Burridge 2008-06-25 21:08:29 UTC
David,

These would appear to be two other different issues.

We (the Orca team) don't like uber-bugs. :-)

So ...

Would it be possible to file two new bugs against them
please?

As this is working "as advertised", I plan to check 
the patch in and move the bug to "[pending]".

Thanks.

Comment 10 Joanmarie Diggs (IRC: joanie) 2008-06-25 21:20:38 UTC
(In reply to comment #8)
> and focus in the message list jumped will up the list--guessing here, but I
> think to the top message in the message list that is showing in the main
> Thunderbird window. 

When you delete the current message while viewing that message in its own window, Thunderbird changes the focused item in the message list to be the first item in the list.  If that behavior is not what you would like, then I would encourage you to file an RFE against Thunderbird in the Mozilla bugzilla.  Thanks!
Comment 11 Mike Pedersen 2008-06-25 21:27:22 UTC
 
> Second, I think there is another Mozilla bug. I sent myself three messages to
> do this test. When I deleted the third message, which was the last in the
> message list, the message view window disappeared (I presume planned behavior) 
> and focus in the message list jumped will up the list--guessing here, but I
> think to the top message in the message list that is showing in the main
> Thunderbird window.  (My messages are sorted ascending by message arrival.)  A
> random jump up the list seems inappropriate behavior.  Can anyone else
> duplicate this?
> 
This is indeed a long-standing problem.  When I asked one of the developers about it a while ago I was told that it was hard to determine the new location.  In my opinion focus should return to either the first or last message in the list depending on your sort order.  
> Thanks.
> 

Comment 12 Mike Pedersen 2008-06-27 16:39:57 UTC
works great