GNOME Bugzilla – Bug 540023
change cursor over highlighted URLs only when CTRL is pressed
Last modified: 2021-06-10 14:00:18 UTC
vte and g-t from trunk. Clicking on URL does nothing. Ctrl-clicking shows a dialog saying: Could not open the address “http://bugzilla.gnome.org/show_bug.cgi?id=540022”: Operation not supported
Works here, using g-t, vte, gtk, glib etc. all from svn trunk. This error being displayed means that g_app_info_launch_default_for_uri failed; something seems to be broken on your system.
More precisely, ctrl+click does work here. click without control never did anything, afaik.
Right. But now when I hover the link I see a hand cursor. Wasn't like that previously.
That was fixed in bug 105986. I guess it does suggest that clicking it may have some effect... Do you think we should open the url on simple click, or only show the hand if ctrl is hold down (would need vte changes) ?
Open on single click is fine if we do on release, to not break selection.
Unfortunately that doesn't work. Think click-move-release to select, but you release over something that's matched as a link -> opens the url.
Sure, I meant open URL only if not selecting.
Unfortunately there's no way to find out, afaics. VteTerminal's button-release-event handler always consumes the event.
Created attachment 113371 [details] [review] concept patch I thought this might work, but it didn't.
(In reply to comment #9) > Created an attachment (id=113371) [edit] > concept patch > > I thought this might work, but it didn't. I have a memory that I experimented with this before. One way is o call the vte release method, then check selection... ugly. Another is to fix vte... Yeah, see bug 13299.
So, given bug 13299, I think making click open URLs is a wrong thing to do. Lets focus on the rest of this bug.
The remainder being that g_app_info_launch_default_for_uri returns failure. Which glib and gtk versions? If svn, have you tried updating from svn?
(In reply to comment #12) > The remainder being that g_app_info_launch_default_for_uri returns failure. And the hand icon that shouldn't be there. Maybe we can do a tooltip to suggest ctrl+click or something. But given that it's in the context menu, I wouldn't bother. > Which glib and gtk versions? If svn, have you tried updating from svn? Compiling trunk.
(In reply to comment #12) > The remainder being that g_app_info_launch_default_for_uri returns failure. > Which glib and gtk versions? If svn, have you tried updating from svn? Still happening with glib and gtk trunk. (I also noticed that if I move the cursor from the sides to the URL, it doesn't recognize the URL. If I move from above or below, it does.)
(In reply to comment #14) > (In reply to comment #12) > > The remainder being that g_app_info_launch_default_for_uri returns failure. > > Which glib and gtk versions? If svn, have you tried updating from svn? > > Still happening with glib and gtk trunk. Does gvfs-open work on the same URLs? > (I also noticed that if I move the cursor from the sides to the URL, it doesn't > recognize the URL. If I move from above or below, it does.) Sometimes it seems the cursor has to get about in the middle of the 1st/last character for the highlighting to occur, but on the next try it works at the border. Odd.
(In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #12) > > > The remainder being that g_app_info_launch_default_for_uri returns failure. > > > Which glib and gtk versions? If svn, have you tried updating from svn? > > > > Still happening with glib and gtk trunk. > > Does gvfs-open work on the same URLs? Humm, no, I get the same error: $ gvfs-open http://behdad.org/ gvfs-open: http://behdad.org/: error opening location: Operation not supported Something wrong with my system then... > > (I also noticed that if I move the cursor from the sides to the URL, it doesn't > > recognize the URL. If I move from above or below, it does.) > > Sometimes it seems the cursor has to get about in the middle of the 1st/last > character for the highlighting to occur, but on the next try it works at the > border. Odd. From the sides I can pass over the entire URL without it noticing.
So should we revert bug 105986, or add vte API to only hightlight when Ctrl is pressed, or live with hand cursor on links even without control?
Umm, I'd say add vte API to only hightlight when Ctrl is pressed, but only if we can add a decent generic API that makes sense.
Retitling.
*** Bug 560289 has been marked as a duplicate of this bug. ***
any love on this one?
ChPe, can you suggest vte API for this? Alternatively we can simply drop the hand icon altogether.
-> vte, will address this on vte-next
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/1518.