After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539971 - Support media player keys
Support media player keys
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-24 15:18 UTC by Bastien Nocera
Modified: 2008-06-24 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Aforementioned patch (10.59 KB, patch)
2008-06-24 15:27 UTC, Bastien Nocera
none Details | Review
Updated (14.58 KB, patch)
2008-06-24 17:52 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2008-06-24 15:18:21 UTC
Patch does that, pretty much.

The only things left to do:
- fix up when compiling without d-bus support
- actually implement the actions in ev-window.c
- remove debug in the patch

For that last one, how do you want me to export the functions from Evince?
Comment 1 Bastien Nocera 2008-06-24 15:27:24 UTC
Created attachment 113340 [details] [review]
Aforementioned patch
Comment 2 Bastien Nocera 2008-06-24 17:52:18 UTC
Created attachment 113349 [details] [review]
Updated

Problems mentioned above should be fixed now.
Comment 3 Bastien Nocera 2008-06-24 18:16:05 UTC
Committed to trunk after a few review changes by Nickolay and Carlos.

2008-06-24  Bastien Nocera  <hadess@hadess.net>

	* shell/Makefile.am:
	* shell/ev-application.c (ev_application_init),
	(ev_application_get_media_keys):
	* shell/ev-application.h:
	* shell/ev-marshal.list:
	* shell/ev-media-player-keys.c (ev_media_player_keys_class_init),
	(proxy_destroy), (on_media_player_key_pressed),
	(ev_media_player_keys_init), (ev_media_player_keys_focused),
	(ev_media_player_keys_finalize), (ev_media_player_keys_new):
	* shell/ev-media-player-keys.h:
	* shell/ev-window.c (ev_window_go_previous_page),
	(ev_window_go_next_page), (ev_window_go_first_page),
	(ev_window_go_last_page), (ev_window_start_presentation),
	(ev_window_dispose), (view_actions_focus_in_cb):
	* shell/ev-window.h: When building with D-Bus support, listen
	for multimedia key events from gnome-settings-daemon. This allows
	to go to the next/previous/first/last pages using, respectively,
	Next/Previous/Rewing/Fast Forward. The Play button is used to start
	a presentation. Fixes bug #539971.