Bug 539967 – nautilus crashes when opening folder containing certain .desktop file

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 539967 - nautilus crashes when opening folder containing certain .desktop file


Summary:	nautilus crashes when opening folder containing certain .desktop file


Status:	RESOLVED DUPLICATE of bug 546256

Product:	gvfs
Classification:	Core
Component:	daemon
Version:	0.99.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	gvfs-maint
QA Contact:	gvfs-maint

URL:
Whiteboard:

Duplicates:	551363 (view as bug list)
Depends on:
Blocks:

Reported:	2008-06-24 15:03 UTC by Sebastien Bacher
Modified:	2008-09-08 13:35 UTC

See Also:
GNOME target:	---
GNOME version:	2.23/2.24

Attachments
a patch (322 bytes, patch) 2008-08-16 01:07 UTC, Matthias Clasen	none	Details \| Review

Description Sebastien Bacher 2008-06-24 15:03:25 UTC

the bug has been opened on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/235544

"When the folder is opened, nautilus crashes and restarts, with this line in /var/log/syslog:

kernel: [ 3425.325654] nautilus[9824]: segfault at 00000000 eip b69e6f97 esp bf88b470 error 4

Symptoms are similar to Bug #127826. I'm using nautilus 2.22.2 in Ubuntu 8.04 (32-bit) with updates.

Steps to reproduce this bug:

  * create a new directory
  * create a file in this directory called "test.desktop" which contains:

[Desktop Entry]
Version=1.0
Encoding=UTF-8
Name=test
Type=Link
URL=http://google.com/A%2FB
Icon=gnome-fs-bookmark
Name[en_US]=test

  * browse to this new folder (or a link to this folder) in nautilus
  * nautilus crashes
  * removing the "%2F" from test.desktop causes nautilus to NOT crash"

The crash stacktrace:

"g_mount_spec_canonicalize_path (path=0x0) at gmountspec.c:480
480	  if (*path != '/')
(gdb) bt

+ Trace 201264

#0 g_mount_spec_canonicalize_path
at gmountspec.c line 480
#1 g_daemon_file_new
at gdaemonfile.c line 99
#2 g_daemon_vfs_get_file_for_uri
at gdaemonvfs.c line 374
#3 IA__g_vfs_get_file_for_uri
at /build/buildd/glib2.0-2.17.2/gio/gvfs.c line 122
#4 IA__g_file_new_for_uri
at /build/buildd/glib2.0-2.17.2/gio/gfile.c line 4774
#5 link_info_done
at nautilus-directory-async.c line 3575
#6 link_info_nautilus_link_read_callback
at nautilus-directory-async.c line 3642
#7 IA__g_simple_async_result_complete
at /build/buildd/glib2.0-2.17.2/gio/gsimpleasyncresult.c line 553
#8 load_contents_close_callback
at /build/buildd/glib2.0-2.17.2/gio/gfile.c line 5148
#9 async_ready_close_callback_wrapper
at /build/buildd/glib2.0-2.17.2/gio/ginputstream.c line 487
#10 IA__g_simple_async_result_complete
at /build/buildd/glib2.0-2.17.2/gio/gsimpleasyncresult.c line 553
#11 complete_in_idle_cb
at /build/buildd/glib2.0-2.17.2/gio/gsimpleasyncresult.c line 563
#12 g_idle_dispatch
at /build/buildd/glib2.0-2.17.2/glib/gmain.c line 4168
#13 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.17.2/glib/gmain.c line 2063
#14 g_main_context_iterate
at /build/buildd/glib2.0-2.17.2/glib/gmain.c line 2696
#15 IA__g_main_loop_run
at /build/buildd/glib2.0-2.17.2/glib/gmain.c line 2919
#16 IA__gtk_main
at /home/seb128/boulot/package/gtk+2.0/gtk+2.0-2.13.3/gtk/gtkmain.c line 1169
#17 main
at nautilus-main.c line 581

Comment 1 Matthias Clasen 2008-08-16 01:07:42 UTC

Created attachment 116717 [details] [review]
a patch

Here is a patch that fixes this crash for me.

Comment 2 Matthias Clasen 2008-08-16 22:49:39 UTC

Also worth pointing out that we probably need to free spec and host when we are returning FALSE...

Comment 3 Christian Kellner 2008-09-05 10:46:08 UTC

I am pretty sure that is actually the same as bug #546256. Also I think the patch just fixes the symptom. The real fix is to never have path == NULL && mount_spec != NULL (which is the real bug)

*** This bug has been marked as a duplicate of 546256 ***

Comment 4 Bastien Nocera 2008-09-08 13:35:32 UTC

*** Bug 551363 has been marked as a duplicate of this bug. ***