After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539395 - The Seek Bar doesn't update when seeking made the song change
The Seek Bar doesn't update when seeking made the song change
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other All
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-21 00:59 UTC by Michał Sawicz
Modified: 2009-08-07 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Hide base Sensitive property with new one (1.14 KB, patch)
2009-08-07 01:24 UTC, Neil Loknath
none Details | Review
New one (1.12 KB, patch)
2009-08-07 02:30 UTC, Neil Loknath
committed Details | Review

Description Michał Sawicz 2008-06-21 00:59:44 UTC
Please describe the problem:
When you try to seek the song and move too far to the right, the song ends and the next starts playing, but the slider 'hangs' on the last known position (though proportionally to the new song's length) and the label doesn't show current time anymore.

Steps to reproduce:
1. play a song
2. move the slider to the right
3. the song switches, the slider hangs


Actual results:


Expected results:
The slider follows the new song's position.

Does this happen every time?
Yes.

Other information:
Comment 1 Bertrand Lorentz 2008-06-21 08:50:21 UTC
I'm able to reproduce this, with the following added precision to the steps :

1. play a song
2. move the slider to the right of the slider and keep the mouse button pressed for a short time, until the song switches
3. the song switches, release the mouse button, the slider hangs
Comment 2 Neil Loknath 2009-08-07 01:24:06 UTC
Created attachment 140082 [details] [review]
Hide base Sensitive property with new one

The problem seems to be that the ButtonRelease event does not get raised if the the Sensitive property is set to false while the button is pressed on the slider. This patch seems to resolve that and allows my patch for http://bugzilla.gnome.org/show_bug.cgi?id=591016 to work properly as well.
Comment 3 Neil Loknath 2009-08-07 02:26:30 UTC
Actually, if going this route, I think it makes more sense to change the if statement from:

if (!base.Sensitive && value) {

to:

if (!value) {
Comment 4 Neil Loknath 2009-08-07 02:30:11 UTC
Created attachment 140083 [details] [review]
New one

Forgot something, so just attaching a new patch to make it easier.
Comment 5 Bertrand Lorentz 2009-08-07 14:30:05 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Neil, thanks for the patch !
Committed to git master.