After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538984 - fix GLib includes
fix GLib includes
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: general
2.23.x
Other Linux
: Normal trivial
: future
Assigned To: libgnomeui maintainers
libgnomeui maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-18 17:06 UTC by Felix Riemann
Modified: 2008-06-18 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove single includes (1.11 KB, patch)
2008-06-18 17:08 UTC, Felix Riemann 		none Details | Review
handle gtk and gdk also (18.93 KB, patch)
2008-06-18 21:16 UTC, Felix Riemann 		committed Details | Review

Description Felix Riemann 2008-06-18 17:06:41 UTC 
From Glib-2.17 README:
The recommended way of using GLib has always been to only include the toplevel headers glib.h, glib-object.h and gio.h.

There is three places in libgnomeui where a specific GLib header is included.
Comment 1 Felix Riemann 2008-06-18 17:08:04 UTC 
Created attachment 112996 [details] [review]
remove single includes

This "fixes" the mentioned single includes. This doesn't make libgnomeui compilable with G_DISABLE_SINGLE_INCLUDES as gnome-vfs is not fixed(yet?).
Comment 2 Christian Persch 2008-06-18 17:11:26 UTC 
Want to do the gtk/gtk.h dance at the same time?
Comment 3 Felix Riemann 2008-06-18 21:16:21 UTC 
Created attachment 113013 [details] [review]
handle gtk and gdk also

(In reply to comment #2)
> Want to do the gtk/gtk.h dance at the same time?
> 

Okay, this one should take care of GTK and GDK single includes as well.
Comment 4 Felix Riemann 2008-06-18 21:31:02 UTC 
Okay, committed. Thanks for the quick response. :-)

2008-06-18  Felix Riemann  <>

	* libgnomeui/*.c:
	* libgnomeui/*.h:
	* test-gnome/prop-editor.h:
	Fix Glib, Gdk and GTK+ single includes. Fixes bug #538984.