Created attachment 112811 [details] [review]
the patch

Created attachment 112812 [details] [review]
with the diff done at the root of gtk

But...thats not the same images... I think I prefer it the way it is, with the content of the icon view being clearly application data, not images that came from the toolkit.

This looks to me like an arbitrary decision led by the taste of one person.

Using stock icons is clearly better suited since they actually depend on the theme of the user. So anyone still has the choice of using any icons but nobody is forced to use the provided images.

(In reply to comment #2)
> Created an attachment (id=112812) [edit]
> with the diff done at the root of gtk

Incidentally please use 'diff -p' in the future (or a script containing '/usr/bin/diff -up --label "${3}" ${6} --label "${5}" ${7}' in the case of svn).

Christian, the theme of the user doesn't even come into play here. This is a tool that is run offline to generate image for the api docs. It never touches 
a user system. 

We can talk about replacing the current images by different ones. But using stock icons is not the right thing.

(mid-air collision)

(In reply to comment #3)
> But...thats not the same images... I think I prefer it the way it is, with the
> content of the icon view being clearly application data, not images that came
> from the toolkit.
> 

My point was to put modern pixmaps, and as the key of the code was not the pictures by themself but the icon-view, I thought I could load pixmaps from the theme.
IF you want I can provide a patch to change the icons for widgets.c and makefile.am, and upload modern icons.

Cheers.

(In reply to comment #6)
> Christian, the theme of the user doesn't even come into play here. This is a
> tool that is run offline to generate image for the api docs. It never touches 
> a user system. 

I guess my wording was somewhat unclear. What I meant basically is, that using stock icons means that for instance current GNOME icons can be used, the *user* here being a developer who runs a recent system. This would have the advantage that if icons start to look "old" again, one of the icon theme guys would probably already have updated the default icons.

> We can talk about replacing the current images by different ones. But using
> stock icons is not the right thing.

If your position is not as nostalgic as I read it, I see that as an option. I don't have a strong opinion, I just thought of it as less of a burden on designers.

Created attachment 113600 [details]
screenshot using a other files

I keep a GNOME foot just updated to the latest version and a folder
patch and icons coming

Created attachment 113601 [details] [review]
the patch

Created attachment 113602 [details]
icons

I can do the commit if you want.

cheers

Looks fine to me, please commit

        * docs/tools/Makefile.am:
        * docs/tools/folder.png:
        * docs/tools/gnome.png: New images

        * docs/tools/widgets.c: Use the new images.
        Patch by Baptiste Mille-Mathias.