GNOME Bugzilla – Bug 538543
Folder Export: tags patch
Last modified: 2008-06-17 10:57:34 UTC
I have created a patch against F-Spot 0.4.4 that does the following: It adds an option to the Folder Export to export HTML about tags also. When checked, it will make a page listing the tags present in these images, a set of index pages for each tag, and every picture will have a list of its tags placed on its page. I checked it, and the style conforms to your guidelines, and the links are all valid. I believe this patch should work against the trunk, but the trunk wasn't compiling for me, so I just worked against 0.4.4. In my opinion, this greatly improves the usefulness of the Folder Export, since I spent a great deal of time tagging my photos and do not want to lose that data. (I cannot attach the patch in this bug submission form; I'll try to attach it once the bug is submitted.)
Created attachment 112808 [details] [review] The patch: adds tags to folder export in f-spot 0.4.4 This is the patch I describe.
maybe similar idea was already at bug 336178
(In reply to comment #2) Hmm. I guess you're right. Still, it looks like that other patch is against a much older version (0.1.10). In any case, I'll be happy as long as the feature ends up in the next release. It's a shame that I spent an unnecessary day, but I guess that's what I get for assuming no one else had thought of this before.
I was wrong, the other bug was slightly different: it was about the option to export tag ICONS below images. Maybe you could merge that code into your, so you will display tag icons instead of names only, which look nicer (and will close two bugs :))! It shouldn't be hard. Two notes about this patch: - Please check all strings you introduce are translatable. At least one exists ("All Photos"), but didn't go further in checking. - The "Include tags" option in export window should be enabled when selecting "Standalone web gallery" only. After those modification I think the patch will be committed. Thanks.
Okay. I have modified the patch so that: - The tag icons are also exported, with their own checkboxes - The strings are translatable - The checkboxes are disabled correctly I will attach the latest patch.
Created attachment 112889 [details] [review] A patch to allow folder export with tags and icons
thanks. committed in r4069. will be uploaded soon to the online repository.