After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538182 - pango_cairo_context_update_layout is not noop after gtk_widget_create_pango_layout
pango_cairo_context_update_layout is not noop after gtk_widget_create_pango_l...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-06-13 18:33 UTC by Behdad Esfahbod
Modified: 2014-08-27 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (903 bytes, patch)
2008-06-13 18:38 UTC, Behdad Esfahbod 		none Details | Review
patch (903 bytes, patch)
2008-06-13 18:38 UTC, Behdad Esfahbod 		accepted-commit_now Details | Review

Description Behdad Esfahbod 2008-06-13 18:33:07 UTC 
But it should.  The reason is that GTK+ uses _DEFAULT values ins some font options where Pango expects a fully resolved (no DEFAULTs) font options...
Comment 1 Behdad Esfahbod 2008-06-13 18:38:03 UTC 
Created attachment 112700 [details] [review]
patch
Comment 2 Behdad Esfahbod 2008-06-13 18:38:29 UTC 
Created attachment 112701 [details] [review]
patch
Comment 3 Matthias Clasen 2008-06-14 18:43:22 UTC 
Looks fine to me. You certainly know better than me what cairo expects...
Comment 4 Behdad Esfahbod 2008-06-16 18:53:43 UTC 
2008-06-16  Behdad Esfahbod  <behdad@gnome.org>

        Bug 538182 – pango_cairo_context_update_layout is not noop after
        gtk_widget_create_pango_layout

        * gtk/gtksettings.c (settings_update_font_options): Make sure all
        font option fields are set to non-DEFAULT values.
Comment 5 jessevdk@gmail.com 2014-08-27 06:13:07 UTC 
I would like to know a bit more details about why it is necessary to have non-DEFAULT default values. I recently filed bug 735316 which sets them back to _DEFAULT (not knowing about this bug) due to font rendering issues on OS X. It looks like it's working fine, but I guess I'm missing something about the implications of settings things to _DEFAULT. What would be the correct way to get system configured rendering working for OS X?
Comment 6 Matthias Clasen 2014-08-27 14:37:59 UTC 
It is extremely unlikely that behdad is going to see your comment on an old, closed bug. Much better to find him on irc.
Comment 7 Matthias Clasen 2014-08-27 14:39:07 UTC 
basically, my reading of the commit message is that the assumption is that the cairo DEFAULT value is just an alias for one of the other options - which seems to be not true for the OS X backend.
Comment 8 jessevdk@gmail.com 2014-08-27 14:46:28 UTC 
Well, I was assuming he would get notified by e-mail, but I'll try to catch him live on IRC then. The DEFAULT value means different things for different backends, usually it means GRAY, but on OS X it means system default (i.e. don't touch any settings).

I guess the other solution would be to implement xft-rgba and xft-antialias for the quartz gdk screen settings.