After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 538005 - Add "Genre" to library browser
Add "Genre" to library browser
Status: RESOLVED DUPLICATE of bug 540873
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal enhancement
: 1.x
Assigned To: Alexander Kojevnikov
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-12 15:35 UTC by Adolfo González Blázquez
Modified: 2010-06-11 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Added an option to show the genre filter (12.08 KB, patch)
2009-04-23 02:52 UTC, Alexander Kojevnikov
none Details | Review
Clearing the genre selection before hiding the filter view (12.24 KB, patch)
2009-04-23 03:16 UTC, Alexander Kojevnikov
none Details | Review
Fixed internet radio and podcasting filter views. (13.27 KB, patch)
2009-04-29 08:28 UTC, Alexander Kojevnikov
none Details | Review
FiltersChanged usage (12.80 KB, patch)
2009-05-22 03:57 UTC, Alexander Kojevnikov
none Details | Review
Add Genre Browser pane to 1.6.0 (12.64 KB, patch)
2010-04-29 10:12 UTC, Xepher
none Details | Review

Description Adolfo González Blázquez 2008-06-12 15:35:02 UTC
It would be great to add another option to the browser to filter by Genre.

In a large library, browsing by artist and album is not enough. Say you have 500+ artists, it's quite complicated to find what your looking for using just the mouse (ok, with the keyboard and the search entry is easier, but i'm using just the mouse).

With another filter, like Genre, you can limit your artist list easily. This works for rhythmbox, iTunes, and others. Why not for Banshee?

And (maybe this is asking too much), the user could add options to the browser, and select which filter will use each option. I mean, something like gktpod does...
Comment 1 Adam Theo 2008-06-25 03:16:34 UTC
I also would like to see this. Genres are a very important part of my library, and how I listen to music. If this feature is ever implemented, it may need to take into account #487281 (not just multiple genres, but also multiple artists and even albums).

However, what do you mean by "you could options to the browser"? Do you mean be able to add other categories to list by instead of just Artist/Album/Genre? If that's the case, maybe smart lists would have to suffice if that is too messy to implement and integrate into the GUI?
Comment 2 Aaron Bockover 2008-06-25 16:15:32 UTC
The genre browser is added.
Comment 3 Adolfo González Blázquez 2008-07-31 10:54:41 UTC
Is this really added? I'm using 1.2.0 and I can't get the genre browser...
Comment 4 Andrew Conkling 2008-07-31 13:21:35 UTC
I'm not sure, but I think a recent commit caused this to go away, with the longer-term goal to be to have the browser sections be configurable. It's certainly not present right now (I think because we're missing the UI control of the sections). Reopening.
Comment 5 Wouter Bolsterlee (uws) 2008-09-17 15:29:43 UTC
What about "super smart playlists" that take a certain metadata field and generate a "subplaylist" for each different value of it? That way you can have a "super smart playlist" using the "Genre" metadata field, and it'll end up like this:

- Now Playing
- Play Queue
- Music Library
  - Some manually crafted playlist
  - Another one
  - Supersmart Genre Playlist
    - Classical
    - Pop
    - Folk
- Video Library
  - Favourites
- Podcasts
- etc.
Comment 6 Gabriel Burt 2008-10-08 20:52:59 UTC
uws, that's a totally different feature - please open new bugs for new issues, and keep bug reports specific to one thing.
Comment 7 Wouter Bolsterlee (uws) 2008-10-08 21:49:17 UTC
Well, Gabriel, I just added the comment because I was browsing bug and my idea would be another approach to the feature discussed in this report, i.e. "genre browsing".
Comment 8 Kevin 2009-02-05 01:32:45 UTC
I, too, would love to have an option to browse by Genre. Not sort by genre,
which, obviously, already exists, but to browse in the same manner as one can
Artist and/or Album.

Additionally, it would be beneficial to have an option to view the browse
window for each of these three options. I am thinking in the manner of the
Listen application. Why? Because I albums are a complete waste to me. And with
the number of app's that do not include genre to begin with, I'm assuming genre
is a waste to others. Therefore, customize your browse window with only the
options you do want. For me, Artist and Genre only.
Comment 9 Alexander Kojevnikov 2009-02-16 01:47:39 UTC
It looks like the genre browser was disabled on 2008-07-24, are there plans to add it back?

This feature is essential for managing a library that has more than just a few hundreds of songs in it.
Comment 10 Alexander Kojevnikov 2009-04-22 08:50:28 UTC
(In reply to comment #8)
> Additionally, it would be beneficial to have an option to view the browse
> window for each of these three options. I am thinking in the manner of the
> Listen application. Why? Because I albums are a complete waste to me. And with
> the number of app's that do not include genre to begin with, I'm assuming genre
> is a waste to others. Therefore, customize your browse window with only the
> options you do want. For me, Artist and Genre only.

This is actually bug 540873
Comment 11 Alexander Kojevnikov 2009-04-23 02:52:23 UTC
Created attachment 133158 [details] [review]
Added an option to show the genre filter

The patch adds the option under Preferences / Source Specific / Music Library / Misc, let me know if you rather see it in the main menu.

I'm also unsure if an event in MusicLibrarySource is a proper way to notify the UI when the setting is changed. Same notification method is probably going to be used for bug 577680, so let me know if you have a more elegant solution to this.
Comment 12 Alexander Kojevnikov 2009-04-23 03:16:28 UTC
Created attachment 133159 [details] [review]
Clearing the genre selection before hiding the filter view
Comment 13 Alexander Kojevnikov 2009-04-29 08:28:14 UTC
Created attachment 133543 [details] [review]
Fixed internet radio and podcasting filter views.
Comment 14 Malte 2009-05-21 01:07:32 UTC
The patch works fine for me. Thanks a lot! This makes Banshee a much better app for me.
Comment 15 Alexander Kojevnikov 2009-05-22 03:57:13 UTC
Created attachment 135152 [details] [review]
FiltersChanged usage

Using DatabaseSource.FiltersChanged event as suggested by Gabriel.
Comment 16 Alex Launi 2009-06-09 22:39:59 UTC
I thought that part of the point of this was to make the browser configurable. I dont care about what genre my music is, and having the genre browser wastes precious space for artists and albums. We should be able to have browsers for arbitrary categories, for instance I could have a genre and year browser. I'm pretty sure gabriel made a mockup for this a looong time ago.
Comment 17 Alex Launi 2009-06-09 22:56:28 UTC
http://banshee-project.org/~gburt/tmp/filter_menu_mockups/

thought these might be useful
Comment 18 Alexander Kojevnikov 2009-06-10 00:38:06 UTC
(In reply to comment #16)
> I thought that part of the point of this was to make the browser configurable.
> I dont care about what genre my music is, and having the genre browser wastes
> precious space for artists and albums. We should be able to have browsers for
> arbitrary categories, for instance I could have a genre and year browser. I'm
> pretty sure gabriel made a mockup for this a looong time ago.
> 

Yep, Gabriel hinted that the genre filter should be added along with other configurable filters in bug 540873. The only reason I'm not closing this bug as a duplicate is because it has a working patch which some people may find useful :)
Comment 19 Gabriel Burt 2009-10-27 20:17:52 UTC
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address.  It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Comment 20 Alexander Kojevnikov 2010-02-15 06:54:59 UTC
Reversed the dependency on bug 540873
Comment 21 Xepher 2010-04-29 10:12:43 UTC
Created attachment 159859 [details] [review]
Add Genre Browser pane to 1.6.0

Updated the patch from Alexander Kojevnikov above to work with Banshee 1.6.0. Compiled clean and seems to work as expected. No deep testing done.
Comment 22 Alexander Kojevnikov 2010-05-29 03:18:20 UTC
I committed the patch to a newly created branch called `browser-filters`. Further work on bug 540873 will be done in that branch.

*** This bug has been marked as a duplicate of bug 540873 ***
Comment 23 Jeff 2010-06-11 07:56:43 UTC
(In reply to comment #22)
> I committed the patch to a newly created branch called `browser-filters`.
> Further work on bug 540873 will be done in that branch.
> 
> *** This bug has been marked as a duplicate of bug 540873 ***

Could you please help me understand what I need to do in order to apply this patch to Banshee? Thank you.
Comment 24 Alexander Kojevnikov 2010-06-11 08:07:14 UTC
(In reply to comment #23)
> Could you please help me understand what I need to do in order to apply this
> patch to Banshee? Thank you.

See http://banshee-project.org/contribute/write-code/ and all the linked pages.

If it's not clear after reading, stop by the #banshee channel on irc.gnome.org, bug tracker is not the best place for this.