After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537868 - Restore window when rhythmbox is closed from tray icon
Restore window when rhythmbox is closed from tray icon
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 631791 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-11 20:54 UTC by Luca Ferretti
Modified: 2010-10-09 23:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Always starts Rhythmbox with main window visible (1.13 KB, patch)
2010-06-21 04:38 UTC, Robert Ancell
none Details | Review
this seems to do what i want (5.20 KB, patch)
2010-06-23 07:29 UTC, Jonathan Matthew
committed Details | Review

Description Luca Ferretti 2008-06-11 20:54:04 UTC
Steps to reproduce:
  * Hide window in tray icon
  * Quit RB (or logout)
  * (Login and) restart RB

Current results
  RB is started, but hidden in notification area

Expected results
  Show RB window
Comment 1 Bastien Nocera 2008-06-11 21:02:09 UTC
I agree there. The problem is the same as in Totem, when hiding controls.

You would be hiding the controls using an icon, or a keyboard shortcut, can't figure out how to get the window back in its original state, so close the program. When restored, the program should show up in the least unexpected state, that is, with the window visible.
Comment 2 Jonathan Matthew 2008-06-30 09:20:53 UTC
This is the inverse of bug 127320.  There don't seem to be any particular arguments for the current behaviour there, other than that a few people seem to like it.
Comment 3 David Prieto 2008-09-15 13:04:43 UTC
I opened a very similar report at Launchpad: https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/270206

I have noticed that RB remembers whether it was minimised to tray when it closed, and starts in the same state. Some users might find that confusing, however. My mother does actually, sometimes she opens RB to listen to her music and she doesn't realise that small white square on the notification area, so she thinks the program didn't start properly.

"I think RB should NEVER start minimised to tray, unless it's specified through a command option".
Comment 4 Robert Ancell 2010-06-21 04:38:05 UTC
Created attachment 164195 [details] [review]
Always starts Rhythmbox with main window visible

Patch applied in Ubuntu Maverick.  Disables the restoring of window visibility on startup.
Comment 5 Robert Ancell 2010-06-21 04:42:30 UTC
The case for remembering window minimization:
Many users run Rhythmbox all the time and treat it like a service.  When they close their session they expect it to be there (in the same state) when they log in again.

So, the real solution is to save the mimimisation state only if Rhythmbox is closed by gnome-session?
Comment 6 Jonathan Matthew 2010-06-21 04:53:45 UTC
That's roughly how I'd like it to work.  I think I'd rather make the decision on startup than on shutdown, though.
Comment 7 Jonathan Matthew 2010-06-23 07:29:31 UTC
Created attachment 164374 [details] [review]
this seems to do what i want

This uses the DESKTOP_AUTOSTART_ID environment variable to figure out whether we were autostarted by the session manager.  eggsmclient unsets this during arg parsing, so we need to grab it early on.  This works for both ~/.config/autostart/ and session saving.
Comment 8 Jonathan Matthew 2010-06-24 06:30:56 UTC
I tripped on this for the last time while attempting to watch the football early this morning.  Pushed as commits 3d6a5b5 and 6c704ee.
Comment 9 Jonathan Matthew 2010-10-09 23:52:35 UTC
*** Bug 631791 has been marked as a duplicate of this bug. ***