GNOME Bugzilla – Bug 537868
Restore window when rhythmbox is closed from tray icon
Last modified: 2010-10-09 23:52:35 UTC
Steps to reproduce: * Hide window in tray icon * Quit RB (or logout) * (Login and) restart RB Current results RB is started, but hidden in notification area Expected results Show RB window
I agree there. The problem is the same as in Totem, when hiding controls. You would be hiding the controls using an icon, or a keyboard shortcut, can't figure out how to get the window back in its original state, so close the program. When restored, the program should show up in the least unexpected state, that is, with the window visible.
This is the inverse of bug 127320. There don't seem to be any particular arguments for the current behaviour there, other than that a few people seem to like it.
I opened a very similar report at Launchpad: https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/270206 I have noticed that RB remembers whether it was minimised to tray when it closed, and starts in the same state. Some users might find that confusing, however. My mother does actually, sometimes she opens RB to listen to her music and she doesn't realise that small white square on the notification area, so she thinks the program didn't start properly. "I think RB should NEVER start minimised to tray, unless it's specified through a command option".
Created attachment 164195 [details] [review] Always starts Rhythmbox with main window visible Patch applied in Ubuntu Maverick. Disables the restoring of window visibility on startup.
The case for remembering window minimization: Many users run Rhythmbox all the time and treat it like a service. When they close their session they expect it to be there (in the same state) when they log in again. So, the real solution is to save the mimimisation state only if Rhythmbox is closed by gnome-session?
That's roughly how I'd like it to work. I think I'd rather make the decision on startup than on shutdown, though.
Created attachment 164374 [details] [review] this seems to do what i want This uses the DESKTOP_AUTOSTART_ID environment variable to figure out whether we were autostarted by the session manager. eggsmclient unsets this during arg parsing, so we need to grab it early on. This works for both ~/.config/autostart/ and session saving.
I tripped on this for the last time while attempting to watch the football early this morning. Pushed as commits 3d6a5b5 and 6c704ee.
*** Bug 631791 has been marked as a duplicate of this bug. ***