GNOME Bugzilla – Bug 537839
Orca does not remember the last position on a webpage in firefox when using the back command
Last modified: 2008-06-23 15:45:55 UTC
Please describe the problem: In firefox, when navigating and following a link, when going back to the previous page, orca does not take you to the last position you were at on the page, IE the link. Instead it takes you all the way to the top of the page Steps to reproduce: 1. 2. 3. 1. Go to a website, IE google.com. 2. Follow a link on the page IE the maps link. 3. Press alt Left arrow to go to the previous page. Actual results: Orca goes back to the top of the page Expected results: Orca should take you to the last place you were at on the previous page, IE the link you followed. Does this happen every time? Yes Other information:
I agree that this would be a really nice to have.
Created attachment 112967 [details] [review] revision 1 This seems to handle it for the test case. I just expanded a check we were doing from editable (i.e. entries) to focusable (i.e. includes entries along with other form fields and links). This patch does *not* cause us to suddenly remember where we were if we were in the middle of some non-linked text. However, I personally am less worried about that. One frequently follows a link or submits a form and then wants go back to continue examining search results or change the form contents. It's less common to be reading a paragraph, feel a need to go back/forward to where you were a minute ago, and then go forward/back to continue reading that paragraph. (Not unheard of, of course, but less of a concern). This is pylinted. I need to run the regression tests. That said, we have very few tests that look at our behavior when using the back button. And fewer still where a page loads and something javascripty initiates a focus grab on an object. So I'd appreciate some hammering on this patch. Thanks!
This is a really really nice improvement. Please feel free to commit.
I definitely agree with the cojmment on just doing this for links, it doesn't make since to go back for text and remember that, just as long as one can read the text under the link one followed.
Patch committed to trunk so that the larger user community can keep hammering on it.