GNOME Bugzilla – Bug 537599
[oggdemux] skeleton streams not skipped in ogg
Last modified: 2008-08-23 15:20:06 UTC
detecting media streams in ogg files with skeleton track fails in gstreamer /usr/share/doc/python-gst0.10/examples/gstfile.py test.ogv Running on test.ogv Mime Type : application/x-annodex Length : 0m 0s 0 Audio: 0m 0s 0 Video: 0m 0s 0 Video : 0 x 0 @ 0/1 fps Other unsuported Multimedia stream : application/x-ogg-skeleton, parsed=(boolean)false this should not happen; instead it should detect the theora and vorbis streams and the corresponding length.
Could you attach such file?
i.e. this one: http://pad.ma/v/Vdx5nvud.ogv
$ /usr/share/doc/python-gst0.10/examples/gstfile.py Vdx5nvud.ogv Running on Vdx5nvud.ogv Mime Type : application/x-annodex It doesn't even try to return length, etc here.
This bug seems to be the same as bug 458404 in the Red Hat bugzilla: [Fedora] Bug 458404 - x-ogg-skeleton element reported as missing when playing many Ogg Theora videos https://bugzilla.redhat.com/show_bug.cgi?id=458404 Here are a couple more sample files that exhibit the problem: http://blip.tv/file/get/Geeko-GregKHTalksAboutTheLinuxKernel503.ogg http://www.gnome.org/~federico/docs/rpm2git/rpm2git-intro.ogg
Created attachment 116224 [details] [review] Skip the skeleton stream when a chain is activated.
The patch above skips the skeleton pad when a chain is activated. The skeleton is parsed inside oggdemux anyway. I doubt that there are apps using the skeleton pad directly so I think it's safe to remove it.
Really annoying as it pops up the plugin install helper for nearly every recent ogg files.
If somebody wants to test the Fedora packages with the patch: http://koji.fedoraproject.org/koji/taskinfo?taskID=779551
Patch works fine for me. $ python /usr/share/doc/gstreamer-python-0.10.11/examples/gstfile.py ~/Desktop/diffmatte.ogv Running on /home/hadess/Desktop/diffmatte.ogv Mime Type : application/x-annodex Length : 0m 20s 555 Audio: 0m 0s 0 Video: 0m 20s 555 Video : 1280 x 800 @ 9/1 fps Codec : Theora Additional information : encoder-version : 3 nominal-bitrate : 45000 encoder : Xiph.Org libTheora I 20071025 3 2 1 extended-comment : recordMyDesktop=0.3.7.3 bitrate : 45000 And removes the error as well.
Makes sense I guess... if nobody disagrees I'll commit the patch this evening.
2008-08-23 Sebastian Dröge <sebastian.droege@collabora.co.uk> Patch by: Alessandro Dessina <alessandro nnva org> * ext/ogg/gstoggdemux.c: (gst_ogg_demux_deactivate_current_chain), (gst_ogg_demux_activate_chain): Don't add pads and activate them for skeleton streams. These are already handled inside oggdemux. Fixes bug #537599.