After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537483 - should be possible to import only selected audio cd songs
should be possible to import only selected audio cd songs
Product: rhythmbox
Classification: Other
Component: Importing
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 585059 585923 (view as bug list)
Depends on:
Blocks: 379004
Reported: 2008-06-09 21:43 UTC by Sebastien Bacher
Modified: 2010-02-21 07:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

add checkbox column for selecting tracks to be extracted (19.92 KB, patch)
2009-06-20 08:33 UTC, Jonathan Matthew
none Details | Review
screenshot (74.29 KB, image/png)
2009-06-20 09:06 UTC, Jonathan Matthew
add checkbox in 'extract' column header (18.61 KB, patch)
2009-12-06 11:29 UTC, Jonathan Matthew
committed Details | Review

Description Sebastien Bacher 2008-06-09 21:43:41 UTC
the current audio cd copy action imports the whole disc, it should be possible to import only the selected songs
Comment 1 Jonathan Matthew 2008-06-09 21:48:31 UTC
You can do this by selecting the tracks you want and dragging them to the library.
Comment 2 Sebastien Bacher 2008-06-10 07:11:25 UTC
oh, that's really non-obvious for users, could the toolbar icon be changed to act on the selection or to display a dialog letting the user choising the copy the disc or the selected songs?
Comment 3 Jonathan Matthew 2009-06-07 14:18:22 UTC
*** Bug 585059 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Matthew 2009-06-15 22:40:00 UTC
*** Bug 585923 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Matthew 2009-06-20 08:33:25 UTC
Created attachment 137055 [details] [review]
add checkbox column for selecting tracks to be extracted

The main thing I'm not sure about here is the positioning of the 'select all' and 'deselect all' menu items.  They don't seem very obvious to me.  I don't think they can go in the main menu bar, and they don't belong in the toolbar either.

Maybe clicking on the column header should alternate between selecting and deselecting all the tracks?

(idea stolen from sound-juicer)
Comment 6 Jonathan Matthew 2009-06-20 09:06:09 UTC
Created attachment 137057 [details]
Comment 7 Bastien Nocera 2009-10-22 22:48:06 UTC
I would put the checkbox in the first actual text column, packed in front of the title.

Note that iTunes doesn't have any "Select all" that will change the status of those checkboxes. I wouldn't bother doing that either, and it would avoid the confusion of what the different "Select All" (changing the selection vs. changing which are checked) are for.
Comment 8 Jonathan Matthew 2009-11-09 12:11:54 UTC
Packing the checkbox into the title column sounds like a better idea, but it doesn't work very well with the editable title field.. you need to select the row before you can change the checkbox, and clicking again too quickly starts playing the track as well as toggling the checkbox.
Comment 9 Jonathan Matthew 2009-12-06 11:29:26 UTC
Created attachment 149196 [details] [review]
add checkbox in 'extract' column header

This version adds a checkbox widget to the column header. Clicking on that toggles the state of the checkbox, and sets the checks for all tracks to match the new state.
Comment 10 Jonathan Matthew 2010-02-21 07:29:09 UTC
pushed in commits 907a91e .. 0abcbbc.