After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536655 - Does not reload the playlist after a long pause
Does not reload the playlist after a long pause
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Last.fm
git master
Other All
: Normal minor
: 2.x
Assigned To: Gabriel Burt
: 538214 543799 547090 571198 585295 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-04 17:03 UTC by Guillaume AVRIL
Modified: 2009-06-10 19:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add Refresh to the station right click menu (2.76 KB, patch)
2008-12-30 06:31 UTC, Garrett Johnson
needs-work Details | Review
Updated to comment #10 (2.76 KB, patch)
2009-03-02 07:58 UTC, Alexander Kojevnikov
committed Details | Review

Description Guillaume AVRIL 2008-06-04 17:03:54 UTC
Add the ability to reload the play list manually. Or reload the play list if no song is readable.

Other information:
To reproduct the bug, lauch banshee, connect to a lastfm group like banshee group (excellent playlist), put the stream in pause and 30 min later start reading back. You need to restart banshee to make it work.
Comment 1 Mikayla Hutchinson 2008-06-04 19:22:09 UTC
Other last.fm stations fail too after a really long pause. They load tracks, but the tracks cannot be played.
Comment 2 Kevin Harriss 2008-06-17 22:04:27 UTC
This problem still occurs in Banshee 1.0.
Comment 3 Peter de Kraker 2008-06-27 21:42:08 UTC
*** Bug 538214 has been marked as a duplicate of this bug. ***
Comment 4 Martin Meyer 2008-08-17 21:35:22 UTC
I see the same issue. I stopped playing from my own recommendations and played two songs from the Banshee Group. I went back and none of my recommendations work anymore.

This is a recurring problem for me, and I have to restart Banshee to get last.fm working again.

I'm using Banshee 1.2.1.
Comment 5 nul.all 2008-08-18 02:26:35 UTC
*** Bug 543799 has been marked as a duplicate of this bug. ***
Comment 6 Emilio Scalise 2008-08-28 15:33:01 UTC
I can confirm this bug on debian, using the 1.2.1 official package.

Please fix this bug.

A button that allow to clear the playlist and reload the station playlist would be sufficient and not too difficult to develop (by someone who knows banshee code well)..

Thanks,
Emilio
Comment 7 Pedro Villavicencio 2008-11-18 00:14:16 UTC
*** Bug 547090 has been marked as a duplicate of this bug. ***
Comment 8 Garrett Johnson 2008-12-30 06:31:31 UTC
Created attachment 125501 [details] [review]
Patch to add Refresh to the station right click menu
Comment 9 Garrett Johnson 2008-12-30 06:33:14 UTC
Comment on attachment 125501 [details] [review]
Patch to add Refresh to the station right click menu

I created this patch to add a Refresh option to the last.fm stations in case they go stale. It's very simple and just takes the new stuff onto the end just like when you listen for a while and you get a new batch of songs to appear. Same function I suppose. I figured some people would be interested in this since it is very annoying.
Comment 10 Bertrand Lorentz 2008-12-30 17:04:32 UTC
Thanks for the patch !
A few comments :
1. The line in StationSource.cs is probably unnecessary : the label that gets displayed is just "Refresh".
2. You can add the RefreshSourceAction in the same call to the Add method as the other 2 actions.
3. I think the "refresh" icon would be appropriate. Just add Stock.Refresh as the 2nd parameter.

Ideally, banshee would refresh automatically when needed, but that's a first step.
Comment 11 Gabriel Burt 2009-02-10 16:37:45 UTC
*** Bug 571198 has been marked as a duplicate of this bug. ***
Comment 12 Alexander Kojevnikov 2009-03-02 07:58:49 UTC
Created attachment 129833 [details] [review]
Updated to comment #10

Also made formatting of LastfmActions.ctor a bit more uniform.
Comment 13 Bertrand Lorentz 2009-03-02 23:42:43 UTC
Patch committed, thanks !

I'm leaving this open, because, as I mentionned, the reload should somehow happen automatically.
Comment 14 Gabriel Burt 2009-06-04 19:18:09 UTC
Closing, good enough.
Comment 15 Andrew Conkling 2009-06-06 02:46:38 UTC
I'm sorry, what's good enough? I've been running git master for the last two weeks, playing solely Last.fm stations in Banshee and get struck with this bug a few times a day.

Am I experiencing something that is possibly unrelated or is this still an issue? I was under the impression it was, so I hadn't filed a bug yet.
Comment 16 Bertrand Lorentz 2009-06-06 10:58:18 UTC
Andrew,
The patch that was committed adds a "Refresh" item in the right click menu of Last.fm stations. So you should be able to manually refresh a station when its tracks have gone "stale".
Comment 17 Andrew Conkling 2009-06-06 13:37:14 UTC
Aha, very nice. I'll test it out and report any feedback.
Comment 18 Bertrand Lorentz 2009-06-10 19:14:33 UTC
*** Bug 585295 has been marked as a duplicate of this bug. ***