GNOME Bugzilla – Bug 534794
Reveal file(s) received in Nautilus
Last modified: 2008-10-02 18:11:49 UTC
Now that we have a notification system, we could add an action to reveal the file in the file-manager. It requires that Nautilus implement some method to open folder (bug #498506).
would you consider to include a bug hack which consist of spawning a nautilus on the folder when the file is downloaded? off course temporarly. I think epiphany has such code too.
Fine by me.
Created attachment 112319 [details] [review] Patch working but it SIGABRs it SIGABR even when I launch the first action added in the notification with: glibc detected *** /opt/gnome/libexec/gnome-user-share: double free or corruption (fasttop): 0x080bcc30 *** so I wonder if I use notification actions in a sane manner.
Created attachment 112328 [details] [review] patch #2 It doesn't crash now :) I chose to have only one NotifyActionCallback and to dispatch to the action inside this function. I removed the g_object_unref (notification) for the NotifyActionCallback, because it doesn't crash now and I don't understand why we unref in it, and once again in on_close_notification. Cheers
Created attachment 112334 [details] [review] few cosmetic changes
There were 2 problems: - libnotify crashes if you use the same data for the 2 different callbacks. I filed: https://bugzilla.redhat.com/show_bug.cgi?id=451001 because upstream isn't very responsive - In the callback, you were calling both notify_notification_close() (which will call the normal close callback), and hide_statusicon(), so the notification count was getting to -1. A couple more things: - Please follow the coding style in the rest of the file (especially the tabs indentation) - Don't use C++ style comments ("//") - and I prefer you use "bleh == FALSE" or "bleh == NULL" rather than "!bleh" 2008-06-12 Bastien Nocera <hadess@hadess.net> * src/obexpush.c (notification_launch_action_on_file_cb), (show_notification): Add a "Reveal File" button on the transfer notifications, patch by Baptiste Mille-Mathias <baptiste.millemathias@gmail.com> (Closes: #534794)
Bug 131259 may be interesting for this bug, I hope to have it fixed in the near future.