Bug 534569 - metacity trunk fails to run since revision 3715
metacity trunk fails to run since revision 3715
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: Iain's compositor
trunk
Other Linux
: Normal critical
: ---
Assigned To: Metacity compositor maintainers
Metacity compositor maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-05-23 23:46 UTC by Elijah Newren
Modified: 2008-05-24 16:48 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Elijah Newren 2008-05-23 23:46:53 UTC 
Revision 3714 seems to work fine for me; revision 3715 (Iain's changes to add basic public compositor API) does not.  With the latter revision, metacity dies during startup--the stacktrace I captured is:

+ Trace 198501

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/libpthread.so.0
  • #2 g_spawn_sync
    from /lib/libglib-2.0.so.0
  • #3 g_spawn_command_line_sync
    from /lib/libglib-2.0.so.0
  • #4 run_bug_buddy
    at gnome-breakpad.cc line 213
  • #5 check_if_gdb
    at gnome-breakpad.cc line 283
  • #6 google_breakpad::ExceptionHandler::InternalWriteMinidump
    at ../google-breakpad/src/client/linux/handler/exception_handler.cc line 225
  • #7 google_breakpad::ExceptionHandler::HandleException
    at ../google-breakpad/src/client/linux/handler/exception_handler.cc line 196
  • #8 <signal handler called>
  • #9 meta_compositor_set_active_window
    at compositor/compositor.c line 129
  • #10 meta_window_notify_focus
    at core/window.c line 5218
  • #11 event_callback
    at core/display.c line 1898
  • #12 filter_func
    at ui/ui.c line 83
  • #13 ??
    from /usr/lib/libgdk-x11-2.0.so.0
  • #14 ??
  • #15 ??
  • #16 ??
  • #17 ??
  • #18 ??
  • #19 ??
    from /usr/lib/libgdk-x11-2.0.so.0
  • #20 ??
  • #21 ?? 


Also, why are we connecting to bug-buddy?  It turned out to be nice for me because it provided a nice little deadlock that allowed me to more easily connect with gdb from a remote machine, but I'm hardly the person to optimize for.  :-)
Comment 1 iain 2008-05-24 11:01:33 UTC 
Whoops forgot to check for NULL compositor before dereferencing.
Fixed in revision 3723

As for bug-buddy, I dunno, it doesn't kick in here and I didn't do anything to add it.
Comment 2 Elijah Newren 2008-05-24 16:48:09 UTC 
Sweet, thanks for the quick fix.  :)
Note You need to log in before you can comment on or make changes to this bug.