After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534312 - Forwarded mail is not signified in LH column. Nreeds envelope with right arrow
Forwarded mail is not signified in LH column. Nreeds envelope with right arrow
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 203600 (view as bug list)
Depends on:
Reported: 2008-05-22 09:06 UTC by Andrew Greig
Modified: 2013-09-13 00:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

proposed eds patch (1.02 KB, patch)
2008-05-29 17:18 UTC, Milan Crha
committed Details | Review
proposed evo patch (11.46 KB, patch)
2008-05-29 17:30 UTC, Milan Crha
committed Details | Review

Description Andrew Greig 2008-05-22 09:06:52 UTC
Please describe the problem:
In previous incarnations of Evo, a mail message could be seen to have been forwarded, with an icon of an envelope with a blue right facing arrow superimposed.  In fact the same icon used for the "forward" button on the tool bar. Currently only "read" - open envelope, and "replied to" - icon with orange bent arrow pointing to left, are showing.  "forwarded" mail looks the same as "read" mail in the left hand column.

Steps to reproduce:
1. See above description

Actual results:
See above

Expected results:
A forwarded icon should be displayed for the message.

Does this happen every time?

Other information:
Comment 1 Srinivasa Ragavan 2008-05-23 03:39:32 UTC
Andrew you sure? I have never seen that before. I wonder, the source/flags too doesn't seem to support it.
Comment 2 Andrew Greig 2008-05-23 04:00:20 UTC
Hi Srinivasa,

I have been using evo since before v1.x, and I was used to seeing a difference in the icon defining the message in the left column. eg
Unread   Read    Replied  Forwarded  
Now of those four only the first three work.  The icon that should be used is displayed in the tool bar on the "Forward" button.  I am not a developer, just a user, but isn't it a simple thing to apply an icon to an action? In the same way that the REPLY button does?

Maybe it has been missing for a couple of releases. I don't forward much any more, so i have not been paying attention.  But it came up in the Evolution-user list.
Comment 3 Milan Crha 2008-05-27 17:41:38 UTC
Hi Andrew, I guess you misplaced it with a follow-up flag, because there is really no change in a sources showing the possibility to distinguish between read and forwarded mail. It's possible there was some code which marked forwarded mails as answered, same as reply does, but it was rather a bug than a feature (the icon would be same as for a reply, anyway).

It seems like an enhancement request for me. What about some corner cases, like replied first and then forwarded or vice versa, which one has a precedence?
Comment 4 Andrew Greig 2008-05-27 22:27:36 UTC
Hi Milan,
I do not know what a corner case is. I'm not a programmer, just a user. So the question is this:
Can the code which takes the "Reply" icon used on the "Reply" button do the same thing for the "Forward" icon on the "Forward button.

If hitting the reply button opens up a mail window with the sender's name in the address bar AND installs an icon next to the message in the list window, then ... why can't the "Forward" button open up a message window (and all the stuff it does) AND install the "Forward" icon next to the message in the same way.

As I said, I am not a programmer, but isn't the code already there, but just needs an adjustment. Again, I may be off track, but isn't this a trivial amendment?

I don't see it so much as a "feature request" as one that reflects what occurs in every other mail client - the distinction between "replied to" and "forwarded".

Comment 5 Milan Crha 2008-05-29 17:18:01 UTC
Created attachment 111749 [details] [review]
proposed eds patch

for evolution-data-server;

Added new flag. Not much complicated patch for eds, somehow.
Comment 6 Milan Crha 2008-05-29 17:30:28 UTC
Created attachment 111750 [details] [review]
proposed evo patch

for evolution;

This was much complicated, really. I hope I didn't overlook any place when shifting icons. Also, when forwarding non-attached, then it uses same callbacks as the reply, but when forwarding attached, then I used default callbacks and only updated flags on those messages. It should be fine as far as I can tell.
Comment 7 Andrew Greig 2008-05-30 00:43:07 UTC
Hey Milan,

Thanks for your efforts on this.  How do we apply the patch to an installed Evolution? Or do we just wait for the next release?  Very new to this.

Andrew Greig
Comment 8 Matthew Barnes 2008-05-30 00:58:38 UTC
Best to wait until the next release.  You'd have to apply the patch to Evolution's source code, compile it, and then reinstall the application.
Comment 9 Andrew Greig 2008-05-30 01:22:41 UTC
OK, guys, this is fantastic!  I am really grateful.  I love this Open Source thing. Just makes you feel proud.  Do I tell the Evo list about this, or do you?

Such a quick response is a confidence booster to the list.

Andrew Greig

Whatever you recommend I will do, I will not respond again.
Comment 10 Srinivasa Ragavan 2008-05-30 03:28:30 UTC
Sankar/Matt, one of you review and test it for 2.23.3? 
Comment 11 Srinivasa Ragavan 2008-06-02 03:47:50 UTC
** Time out **

Milan, your patch design seems fine. Im approving it. Please test it well and commit it.
Comment 12 Bharath Acharya 2008-06-02 04:45:05 UTC
Committed to EDS Trunk as r8890
Committed to Evo Trunk as r35567
Comment 13 Milan Crha 2008-08-04 13:05:07 UTC
*** Bug 203600 has been marked as a duplicate of this bug. ***