GNOME Bugzilla – Bug 532591
patch to fix python detection (and add libtool 2.2 support)
Last modified: 2008-08-14 13:18:29 UTC
The current python detection "algorithm" is broken. It will hard disable python support even before actually checking for python. This patch fixes the issue and renames some variables for improved clarity. The m4_ifdef line at the top of the patch is for libtool 2.2 which no longer creates ./libtool when calling AC_PROG_LIBTOOL (it is now created with AC_OUTPUT). This macro forces libtool to create its scripts earlier (one of the python detection scripts needs ./libtool). Patch already applied in Gentoo on top of 2.22.2, but svn trunk needs it too. Thanks
Created attachment 110712 [details] [review] totem-2.22.2-fix-python-and-libtool-2.2.patch
Ping?
I'd rather you split those 2 problems in different bugs. For the libtool changes, could you please point me to documentation that would explain why libtool made that behavioural change? And for the Python problem, I don't see in which cases Python could be disabled when present and requested.
(In reply to comment #3) > I'd rather you split those 2 problems in different bugs. I just grouped them for the sake of simplicity, the libtool 2.2 changes only being the first hunk of the patch. > For the libtool changes, could you please point me to documentation that would > explain why libtool made that behavioural change? As I said in the first comment, AC_PROG_LIBTOOL no longer creates the "libtool" script. It's created in AC_OUTPUT so that things are created all at the same time (for consistency I guess? http://www.gnu.org/software/libtool/manual/libtool.html#index-LT_005fOUTPUT-113 http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=blob;f=ChangeLog.2005;hb=HEAD#l1448 that's all I could fine explaining the change) > And for the Python problem, I don't see in which cases Python could be disabled > when present and requested. If using --{en,dis}able-python, it works fine. The second part of the patch just fixes autodetection : On my system, if I just run configure, I will get the following : checking whether Python plugin support is requested... autodetect checking for a Python interpreter with version >= 2.3... python checking for python... /usr/bin/python checking for python version... 2.5 checking for python platform... linux2 checking for python script directory... ${prefix}/lib64/python2.5/site-packages checking for python extension module directory... ${exec_prefix}/lib64/python2.5/site-packages checking whether we can build a shared library depending on libpython... no [...] configure: Python binding support disabled If I run "./configure --enable-python" checking whether Python plugin support is requested... yes checking for a Python interpreter with version >= 2.3... python checking for python... /usr/bin/python checking for python version... 2.5 checking for python platform... linux2 checking for python script directory... ${prefix}/lib64/python2.5/site-packages checking for python extension module directory... ${exec_prefix}/lib64/python2.5/site-packages checking whether we can build a shared library depending on libpython... yes checking for PYGTK... yes checking for pygtk defs... /usr/share/pygtk/2.0/defs checking for pygtk codegen... /usr/bin/python /usr/lib64/python2.5/site-packages/gtk-2.0/codegen/codegen.py checking for pygtk h2def... /usr/bin/python /usr/lib64/python2.5/site-packages/gtk-2.0/codegen/h2def.py [...] configure: ** Python binding support enabled
*** Bug 546563 has been marked as a duplicate of this bug. ***
2008-08-14 Bastien Nocera <hadess@hadess.net> * configure.in: Support libtool 2.2, don't try to check for presence of Python through compiling against it, as libtool is required to compile against it, and libtool isn't available yet during configure Adapted from patches by Rémi Cardona and Patryk Zawadzki (Closes: #532591) Also fix the message telling us whether Vala is enabled