GNOME Bugzilla – Bug 532472
SMTP authentication bugs
Last modified: 2013-09-13 00:58:52 UTC
While investigating bug #354923, I discovered a couple other SMTP authentication bugs. One in Camel, one in Evolution. 1) If we have an invalid password cached (user entered the wrong password or the server password changed), Camel's SMTP provider will keep trying to authenticate with the same password indefinitely, or until the SMTP server gets fed up and hangs up on us (leading to Send/Receive hangs). If our authentication attempt is rejected with a 535 response, we should make sure the user gets prompted for a new password before trying again. 2) In Evolution, mail_config_get_account_by_transport_url() gets a stripped down transport URI (no parameters or authentication mechanisms). Its job is to find a matching EAccount for that URI, but EAccount URIs do store things like parameters and authentication mechanisms. So we need to strip down the EAccount URI before comparing it with the transport URI. Otherwise we may unnecessarily prompt the user for an SMTP password.
Created attachment 110678 [details] [review] Patch for camel-smtp-transport.c Addresses issue #1 above.
Created attachment 110679 [details] [review] Patch for mail-config.c Addresses issue #2 above.
Sankar, can you review this?
ping
Sankar: You need to find time during your busy disk summary schedule :) I wasn't very much aware of mail-config.c changes, but other things are fine. I didnt test it. Just test and commit it.
Committed patches to trunk: evolution (revision 35649) evolution-data-server (revision 9004) Only committing to trunk for now because, despite my testing, I'm still a bit paranoid about breaking something.