After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 532075 - segfault inside append_legacy_session_apps()
segfault inside append_legacy_session_apps()
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
2.23.x
Other Linux
: Normal major
: ---
Assigned To: Session Maintainers
Session Maintainers
: 533351 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-05-08 00:11 UTC by Ed Catmur
Modified: 2008-05-31 20:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
gsession.patch (3.54 KB, patch)
2008-05-08 00:53 UTC, Ed Catmur 		none Details | Review

Description Ed Catmur 2008-05-08 00:11:19 UTC 
On first startup (gnome-session-2.23.1.1, Gentoo gnome-experimental):

Program received signal SIGSEGV, Segmentation fault.

+ Trace 197183

Thread 3071006400 (LWP 25907)

  • #0 IA__g_str_hash
    at gstring.c line 95
  • #1 IA__g_hash_table_lookup
    at ghash.c line 118
  • #2 append_app
    at session.c line 158
  • #3 gsm_session_new
    at session.c line 400
  • #4 main
    at main.c line 133
  • #2 append_app
    at session.c line 158
  • #3 gsm_session_new
    at session.c line 400 

This is actually append_legacy_session_apps() - blame -finline-functions.

Top of ~/.gnome2/session:

[Default]
0,id=117f000001000119868841700000055020003
0,RestartStyleHint=2
0,Priority=40
0,Program=gnome-panel
0,CurrentDirectory=/home/ed
0,CloneCommand=gnome-panel --sm-config-prefix /gnome-panel-jFTiVG/ 
0,RestartCommand=gnome-panel --sm-config-prefix /gnome-panel-jFTiVG/ --sm-client-id 117f000001000119868841700000055020003 --screen 0
Comment 1 Ed Catmur 2008-05-08 00:53:43 UTC 
Created attachment 110558 [details] [review]
gsession.patch
Comment 2 Lucas Rocha 2008-05-16 07:14:04 UTC 
*** Bug 533351 has been marked as a duplicate of this bug. ***
Comment 3 Lucas Rocha 2008-05-31 20:40:51 UTC 
Commited in trunk, thanks!

        Fix crash when appending resumed apps from legacy session file.
        #532075, Ed Catmur. Patch by Ed Catmur.

        * gnome-session/app-resumed.c (get_basename): implement get_basename
        by returning the program name for now. This will probably need to be
        changed in the future with the new session saving implementation based
        on desktop files.
        * gnome-session/app.c (get_basename, gsm_app_get_basename,
        gsm_app_class_init): turn gsm_app_get_basename into an overridable
        method so that we can re-implement it on different types of apps.
        * gnome-session/session.c (append_app): check if basename is NULL
        before checking if app has been registered earlier.