GNOME Bugzilla – Bug 531836
Delete should NOT block on already deleted messages
Last modified: 2008-06-02 05:21:04 UTC
This is a counter-bug to revert bug 352980. While I seriously do not care much about the sensitivity of the Delete button in the toolbar, or the entry in the context menu... Hitting the Del key or Ctrl-D should NOT block the users workflow. As has been mentioned in bug 352980 comment 6, and acknowledged by the reporter in bug 352980 comment 7, it indeed is useful to have Del work on already deleted messages. I myself too am depending upon this feature -- deliberately not hiding deleted messages, and not expunging after each single deletion. Thus, I frequently "skip through a thread" containing previously deleted messages, hitting the Del key repeatedly. I believe most users who deliberately changed the default setting of hiding deleted messages are using similar techniques. A blocking Del seriously gets in the way of these users workflow. In fact, I believe bug 352980 to be pretty much a no-issue. Only users who deliberately disable the default of hiding deleted messages will ever encounter this. And those are likely to actually desire the behavior that has been removed. While I don't care all that much about the sensitivity of the button, I do believe the Del key should "delete again" -- or at the very least, advance in the list without any further action. Also, if the Del key actually works, the button probably should be sensitive for consistencies sake. Also, please note that we have been through this before. The behavior this bug aims at restoring has been approved desired behavior and fixed in the past. Now it is time to fix it a second time. Cc'ing Jeff, Behdad and Srini as per bug 352980. Adding keyword usability. Comment regarding the implementation of the fix for bug 352980: This does NOT work consistently. In fact there is a race between deleting a message a checking weather deletion is an allowed operation. Example: Have a list of mail, not hiding deleted messages. Delete a single mail down that folder, somewhere in the middle. Select the mail further up the list. Press and hold the Del key, seeing lots of mails being deleted one after the other, and while advancing -- simply overriding the previously deleted messages, keeping on deleting even more mail.
Created attachment 110481 [details] [review] proposed fix
(In reply to comment #0) > Also, please note that we have been through this before. The behavior this bug > aims at restoring has been approved desired behavior and fixed in the past. Now > it is time to fix it a second time. Please note that the original comment in the source code, that has been ignored so eloquently, refers to the original Ximian bug number. see http://svn.gnome.org/viewvc/evolution?view=revision&revision=32677 ANY 5 digit Evolution bug number reference can easily be translated into b.g.o bug numbers, by prepending the digit 2. The entire 2xxxxx bug number space in b.g.o are old Ximian bugs. This has been taken care of when migrating Ximian bugzilla to GNOME.
Created attachment 110778 [details] [review] Proposed patch As I said in bug 352980, I have added bonobo accel key for Ctrl+D, Del to keep working on deleted mails, but not the toolbar/menu. This should solve everything.
Does this work for you Guenther? In that case, I can commit it asap.
Im committing it for trunk and stable.
Committed to Trunk as r35570 Committed to Stable as r35571