Bug 531806 – Wrapped item lists don't give proper braille in Gecko

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 531806 - Wrapped item lists don't give proper braille in Gecko


Summary:	Wrapped item lists don't give proper braille in Gecko


Status:	RESOLVED FIXED

Product:	orca
Classification:	Applications
Component:	braille
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	2.24.0
Assigned To:	Eitan Isaacson
QA Contact:	Orca Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-05-06 18:37 UTC by Eitan Isaacson
Modified:	2008-06-18 20:36 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Proposed patch (1.17 KB, patch) 2008-05-06 18:38 UTC, Eitan Isaacson	none	Details \| Review
Proposed patch (1.13 KB, patch) 2008-05-20 18:27 UTC, Eitan Isaacson	committed	Details \| Review
regression test results from using the patch (215.22 KB, text/plain) 2008-05-20 22:43 UTC, Joanmarie Diggs (IRC: joanie)		Details

Description Eitan Isaacson 2008-05-06 18:37:40 UTC

When arrowing over to a list item that span more than one line, the braille output returns weird results that have little to do with the on screen content.

This is a regression since bug #520612.

Comment 1 Eitan Isaacson 2008-05-06 18:38:58 UTC

Created attachment 110472 [details] [review]
Proposed patch

This should fix the strange behavior.

Comment 2 Joanmarie Diggs (IRC: joanie) 2008-05-07 23:18:03 UTC

Thanks! It fails for label guess of entries, however:

Traceback (most recent call last):

+ Trace 197179

File "/usr/lib/python2.5/site-packages/orca/focus_tracking_presenter.py", line 630 in _processObjectEvent
```
s.processObjectEvent(event)
```
File "/usr/lib/python2.5/site-packages/orca/script.py", line 319 in processObjectEvent
```
self.listeners[key](event)
```
File "/usr/lib/python2.5/site-packages/orca/scripts/toolkits/Gecko/script.py", line 2317 in onFocus
```
default.Script.onFocus(self, event)
```
File "/usr/lib/python2.5/site-packages/orca/default.py", line 3071 in onFocus
```
orca.setLocusOfFocus(event, newFocus)
```
File "/usr/lib/python2.5/site-packages/orca/orca.py", line 226 in setLocusOfFocus
```
orca_state.locusOfFocus)
```
File "/usr/lib/python2.5/site-packages/orca/focus_tracking_presenter.py", line 940 in locusOfFocusChanged
```
newLocusOfFocus)
```
File "/usr/lib/python2.5/site-packages/orca/scripts/toolkits/Gecko/script.py", line 2676 in locusOfFocusChanged
```
newLocusOfFocus)
```
File "/usr/lib/python2.5/site-packages/orca/default.py", line 2624 in locusOfFocusChanged
```
self.updateBraille(newLocusOfFocus)
```
File "/usr/lib/python2.5/site-packages/orca/scripts/toolkits/Gecko/script.py", line 2871 in updateBraille
```
regions = [braille.Text(obj, label, " \$l")]
```
File "/usr/lib/python2.5/site-packages/orca/braille.py", line 467 in __init__
```
orca_state.activeScript.getTextLineAtCaret(self.accessible)
```
File "/usr/lib/python2.5/site-packages/orca/scripts/toolkits/Gecko/script.py", line 5874 in getTextLineAtCaret
```
return string, caretOffset, startOffset
```

UnboundLocalError: local variable 'string' referenced before assignment

Comment 3 Eitan Isaacson 2008-05-20 18:27:45 UTC

Created attachment 111245 [details] [review]
Proposed patch

This should fix that traceback above.

Comment 4 Joanmarie Diggs (IRC: joanie) 2008-05-20 22:43:39 UTC

Created attachment 111267 [details]
regression test results from using the patch

Here are the results from running the regression tests with the patch.  Some of the things (e.g. moz_menu.py, saying "space" instead of " ") has nothing to do with this patch.  Of note especially is the whitespace that wasn't there before.

On a positive note, this patch brings back a wayward colon. :-)

I'll re-run the tests now without the patch as we've been checking a lot of stuff in today.

Comment 5 Mike Pedersen 2008-06-04 16:32:18 UTC

Is this waiting on testing for me or the reg tests?

Comment 6 Mike Pedersen 2008-06-04 20:25:17 UTC

Given that Joanie will be doing more work on this related to another bug I think this one is OK to commit.

Comment 7 Eitan Isaacson 2008-06-05 18:04:32 UTC

This patch has been committed to trunk.