After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530315 - Fixup Gtk+ Includes
Fixup Gtk+ Includes
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-28 09:05 UTC by A. Walton
Modified: 2008-05-21 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
here it is. (69.02 KB, patch)
2008-04-28 09:05 UTC, A. Walton 		committed Details | Review

Description A. Walton 2008-04-28 09:05:13 UTC 
Because Mitch says so, http://www.flickr.com/photos/arclnx/2335638271/.

For preparation for the ever forthcoming Gtk+ 3.0 and some fun macro like this:

#if !defined (__GTK_GTK_H_INSIDE__) && !defined (GTK_COMPILATION)
#error "Only <gtk/gtk.h> can be included directly."
#endif

...this is a patch that fixes our includes to only use <gtk/gtk.h>. Touches just about every file, but it's very straightforward, build tested, and works fine here. Doesn't really impact build-time either (2m06 with v. 2m04 w/out on a single test on my 1.6ghz laptop, seems to be within the margin of error).
Comment 1 A. Walton 2008-04-28 09:05:43 UTC 
Created attachment 110024 [details] [review]
here it is.
Comment 2 Christian Neumair 2008-05-19 13:26:04 UTC 
Thanks for your efforts. Please commit the patch to trunk.
Comment 3 Cosimo Cecchi 2008-05-19 19:01:12 UTC 
Setting patch status.
Comment 4 A. Walton 2008-05-21 18:20:17 UTC 
2008-05-21  A. Walton  <awalton@gnome.org>

	* */*.[ch]:
	Move all of Nautilus to single Gtk+ includes, because Mitch says so.
	Closes Bug #530315.