After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 530136 - "Clean Up by Name" should be "Reset by name" or similar
"Clean Up by Name" should be "Reset by name" or similar
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
2.20.x
Other All
: Normal trivial
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-27 00:42 UTC by Lewis Thompson
Modified: 2010-08-03 20:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
WindowsXP and Win7 (84.49 KB, image/png)
2010-06-27 15:22 UTC, Vish
  Details
Change "Clean Up by Name" to "Organize Desktop by Name (1.11 KB, patch)
2010-06-30 17:40 UTC, Marcus Carlson
committed Details | Review
Only show "Organize Desktop by Name" on Desktop (#530136) (1.51 KB, patch)
2010-07-29 22:14 UTC, Marcus Carlson
needs-work Details | Review
Only show "Organize Desktop by Name" on Desktop (#530136) (1.51 KB, patch)
2010-08-02 21:20 UTC, Marcus Carlson
committed Details | Review

Description Lewis Thompson 2008-04-27 00:42:41 UTC
Please describe the problem:
One of the context menu options for the GNOME Desktop is "Clean Up by Name"

This automatically sorts and changes the location of all desktop icons based on filename (with preference to mounted filesystems, network shares and directories)

"Clean Up by Name" label could be more meaningful:

e.g. Sort desktop icons

It probably should not be "Sort desktop icons by name", due to the above mentioned preference towards specific types of icons

Steps to reproduce:
na

Actual results:
na

Expected results:
na

Does this happen every time?
na

Other information:
na
Comment 1 Cosimo Cecchi 2008-04-29 07:31:41 UTC
I don't really have an opinion on this, but I think the best place to discuss such a string change would be the gnome-doc list [1]. If you want, please send a mail (CC-ing also the nautilus mailing list [2]) explaining why that would explain better the action. Thanks.

[1] gnome-doc-list@gnome.org
[2] nautilus-list@gnome.org

(both lists require subscription before posting).
Comment 2 David Siegel 2009-06-19 16:11:11 UTC
"Clean up by name" sounds like a one time action, which is confusing because the menu item is a checkbox. "Arrange by name" gives a better idea of what the effect will be, because the desktop icons will be arranged, not cleaned per se. Even better "Keep arranged by name" makes the effect clear, and agrees with the semantics of the checkbox.
Comment 3 David Siegel 2009-07-07 11:28:46 UTC
My bad -- I didn't realize that the "Clean up by Name" entry is not a checkbox, so it should be interpreted by the user as an action rather than a persistent state setting. I suggest "Arrange Items by _Name", but I will try to get more feedback on this.
Comment 4 Vish 2010-06-27 05:47:12 UTC
This discussion was brought up in the mailing lists : [mailman seems to have swallowed a few mails!]
http://mail.gnome.org/archives/nautilus-list/2010-January/msg00036.html
http://mail.gnome.org/archives/gnome-doc-list/2010-January/msg00051.html

Alternate suggestion on the threads:
 "Sort by Name"
 "Align by Name"
 "Reorder by Name"
 "Assort by Name"
 "Organize Desktop"
 "Organize Desktop Items"

Should we ping the docs team again? There wasnt a response from them the last time.
Comment 5 Allan Day 2010-06-27 10:21:06 UTC
Do we even want this option? The only time I've ever used it it caused a massive mess.

The Desktop isn't intended to be a place where users have loads of files. It's a temporary scratch pad. Plus, a user can navigate to /Desktop using a Nautilus window if they want to view their desktop files according to date/type/name or whatever.

What do Windows and OS X do, out of interest?
Comment 6 Vish 2010-06-27 15:22:04 UTC
Created attachment 164748 [details]
WindowsXP and Win7

(In reply to comment #5)
> 
> What do Windows and OS X do, out of interest?

Windows[XP , 7] has the option as a checkbox. "Auto Arrange"

While the action in Nautilus is a one time action.  
Not sure what OSX does ;)
Comment 7 Allan Day 2010-06-27 16:17:05 UTC
The general problem with this operation is that it has quite dramatic results and it's impossible to get back to the prior state. That's not good.

A toggle which could restore the previous icon arrangement would be a nice solution.
Comment 8 Paul Cutler 2010-06-27 16:40:33 UTC
I agree with Allan that this option is not a good option (especially as you can't get back to a prior state) but that should go in a different bug as a feature enhancement.

From a docs team perspective, I would recommend:

Organize Desktop by Name

We don't want to use "Arrange" as it conflicts with the Nautilus option (View -> Arrange Items -> By Name) and is specific to the desktop.  A separate bug should be opened to document this feature.
Comment 9 Marcus Carlson 2010-06-30 17:40:21 UTC
Created attachment 164980 [details] [review]
Change "Clean Up by Name" to "Organize Desktop by Name

Patch against 2.31.1 - but should be ok for master as well
Comment 10 Cosimo Cecchi 2010-07-01 11:03:03 UTC
Pushed to master.
Comment 11 Marcus Carlson 2010-07-25 22:38:37 UTC
Reopened as this also changed the text in windows where "Organize Desktop by Name" doesn't make sense.
Comment 12 Marcus Carlson 2010-07-29 22:14:24 UTC
Created attachment 166806 [details] [review]
Only show "Organize Desktop by Name" on Desktop (#530136)
Comment 13 Cosimo Cecchi 2010-08-01 13:24:41 UTC
Review of attachment 166806 [details] [review]:

::: src/file-manager/fm-icon-view.c
@@ +730,3 @@
 
+	if (FM_IS_DESKTOP_ICON_VIEW (view)) {
+		gtk_action_set_label (action, "_Organize Desktop by Name ");

You should mark this for translation too.
Comment 14 Marcus Carlson 2010-08-02 21:20:23 UTC
Created attachment 167014 [details] [review]
Only show "Organize Desktop by Name" on Desktop (#530136)

How embarrassing, I should not make patches that late. Here's an updated one.
Comment 15 Cosimo Cecchi 2010-08-02 23:28:39 UTC
Review of attachment 167014 [details] [review]:

Thanks, please commit to master.
Comment 16 Cosimo Cecchi 2010-08-03 20:25:22 UTC
Comment on attachment 167014 [details] [review]
Only show "Organize Desktop by Name" on Desktop (#530136)

I pushed this myself as I want to do a new nautilus release soon.